Ubuntu Push Notifications

Merge lp:~pedronis/ubuntu-push/cclick-gc-blocking-comment into lp:ubuntu-push/automatic

  1. cclick-gc-blocking-comment
  2. Merge into automatic
Proposed by Samuele Pedroni
Status: Merged
Approved by: Samuele Pedroni
Approved revision: 392
Merged at revision: 392
Proposed branch: lp:~pedronis/ubuntu-push/cclick-gc-blocking-comment
Merge into: lp:ubuntu-push/automatic
Diff against target: 12 lines (+1/-1)
1 file modified
click/cclick/cclick.go (+1/-1)
To merge this branch: bzr merge lp:~pedronis/ubuntu-push/cclick-gc-blocking-comment
Reviewer Review Type Date Requested Status
Samuele Pedroni Approve
Review via email: mp+255519@code.launchpad.net

Commit message

make the comment about gc workaround in cclock more explicit

Description of the change

tweak comment in cclick

To post a comment you must log in.
Revision history for this message
Samuele Pedroni (pedronis) wrote :

trivial

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click/cclick/cclick.go'
2--- click/cclick/cclick.go 2015-02-06 17:01:15 +0000
3+++ click/cclick/cclick.go 2015-04-08 14:26:25 +0000
4@@ -51,7 +51,7 @@
5 }
6 ccu.cref = cref
7 runtime.SetFinalizer(holder, func(interface{}) {
8- ccu.cref = nil // 1.3 gc gets confused otherwise
9+ ccu.cref = nil // blocks gc really for now, 1.3 otherwise panics
10 C.g_object_unref((C.gpointer)(cref))
11 })
12 return nil

Subscribers

People subscribed via source and target branches