Merge lp:~pedronis/u1db/setup-py into lp:u1db

Proposed by Samuele Pedroni
Status: Merged
Approved by: John A Meinel
Approved revision: 143
Merged at revision: 143
Proposed branch: lp:~pedronis/u1db/setup-py
Merge into: lp:u1db
Diff against target: 64 lines (+18/-4)
4 files modified
.bzrignore (+2/-0)
MANIFEST.in (+5/-0)
Makefile (+1/-1)
setup.py (+10/-3)
To merge this branch: bzr merge lp:~pedronis/u1db/setup-py
Reviewer Review Type Date Requested Status
John A Meinel (community) Approve
Review via email: mp+84466@code.launchpad.net

Description of the change

basic work on setup.py to get setup.py install and setup.py sdist do something reasonable, including requiring deps under setuptools

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

Do we have to list all the subdirectories explicitly?

review: Approve
Revision history for this message
Samuele Pedroni (pedronis) wrote :

setuptools has something called find_packages, but then the question is whether we want to include tests or not in a normal install. And whether we care to ignore the non setup tool case, or write a some fallback code. The number of packages is still small enough that I didn't want to bother.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2011-10-12 13:25:28 +0000
3+++ .bzrignore 2011-12-05 13:32:23 +0000
4@@ -1,2 +1,4 @@
5 ./build
6+./dist
7+./u1db.egg-info
8 doc/sqlite_schema.html
9
10=== added file 'MANIFEST.in'
11--- MANIFEST.in 1970-01-01 00:00:00 +0000
12+++ MANIFEST.in 2011-12-05 13:32:23 +0000
13@@ -0,0 +1,5 @@
14+include COPYING
15+include Makefile
16+recursive-include doc *.txt
17+# tests
18+recursive-include u1db/tests *.py
19
20=== modified file 'Makefile'
21--- Makefile 2011-11-02 22:37:43 +0000
22+++ Makefile 2011-12-05 13:32:23 +0000
23@@ -1,5 +1,5 @@
24
25-.PHONY: check
26+.PHONY: check check-verbose
27
28 check:
29 python -m testtools.run discover
30
31=== modified file 'setup.py'
32--- setup.py 2011-09-09 17:48:30 +0000
33+++ setup.py 2011-12-05 13:32:23 +0000
34@@ -23,9 +23,13 @@
35 "url": "https://launchpad.net/u1db",
36 "license": "GNU GPL v3",
37 "download_url": "https://launchpad.net/u1db/+download",
38- "packages": ["u1db"],
39- "scripts": [],
40+ "packages": ["u1db", "u1db.backends", "u1db.remote",
41+ "u1db.commandline", "u1db.compat"],
42+ "scripts": ['u1db-client', 'u1db-serve'],
43 "ext_modules": ext,
44+ "install_requires": ["paste", "simplejson", "routes"],
45+ # informational
46+ "tests_require": ["testtools", "testscenarios"],
47 "classifiers": [
48 'Development Status :: 4 - Beta',
49 'Environment :: Console',
50@@ -46,7 +50,10 @@
51 """
52 }
53
54- from distutils.core import setup, Extension
55+ try:
56+ from setuptools import setup
57+ except ImportError:
58+ from distutils.core import setup
59
60 setup(**kwargs)
61
62
63=== modified file 'u1db-client' (properties changed: -x to +x)
64=== modified file 'u1db-serve' (properties changed: -x to +x)

Subscribers

People subscribed via source and target branches