Juju Charms Collection
tanuki-message-hub package

Merge lp:~pedronis/charms/trusty/tanuki-message-hub/SERVICE_ENVIRONMENT-envar into lp:~tanuki/charms/trusty/tanuki-message-hub/trunk

  1. Trusty Tahr (14.04)
  2. SERVICE_ENVIRONMENT-envar
  3. Merge into trunk
Proposed by Samuele Pedroni
Status: Merged
Approved by: Samuele Pedroni
Approved revision: 12
Merged at revision: 12
Proposed branch: lp:~pedronis/charms/trusty/tanuki-message-hub/SERVICE_ENVIRONMENT-envar
Merge into: lp:~tanuki/charms/trusty/tanuki-message-hub/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
templates/upstart.conf (+1/-0)
To merge this branch: bzr merge lp:~pedronis/charms/trusty/tanuki-message-hub/SERVICE_ENVIRONMENT-envar
Reviewer Review Type Date Requested Status
Bret Barker (community) Approve
Review via email: mp+268516@code.launchpad.net

Commit message

introduce a SERVICE_ENVIRONMENT envar, mostly so the code can make simple decisions based on where environment/context-wise (prod/staging etc) it is running, should be used quite sparingly though

Description of the change

introduce a SERVICE_ENVIRONMENT envar, mostly so the code can make decision, should be used sparingly though

To post a comment you must log in.
Revision history for this message
Bret Barker (noise) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/upstart.conf'
2--- templates/upstart.conf 2015-07-22 15:15:27 +0000
3+++ templates/upstart.conf 2015-08-19 16:40:58 +0000
4@@ -17,6 +17,7 @@
5 env SERVICE_NAME=message-hub
6 env SERVICE_APP=message_hub.wsgi:app
7 env SERVICE_DIR=/srv/message-hub/{{ environment }}/message-hub
8+env SERVICE_ENVIRONMENT={{ environment }}
9 env LOG_DIR=/srv/message-hub/{{ environment }}/logs
10
11 script

Subscribers

People subscribed via source and target branches

to all changes: