Merge lp:~pedro/mago/brasero-tests into lp:~mago-contributors/mago/mago-1.0

[Pedro Villavicencio]

Added a Brasero basic test, that burns a directory into an ISO file.

[Jean-Baptiste Lallement (jibel)]

Thanks for your work. I've a few comments though.

* in mago/test_suite/brasero.py
 - The cleanup code is superfluous. If you really want to close the app during cleanup a call to self.application.close() should be enough.
 - The cleanup method could also remove the brasero.iso that the test just created
* mago/application/brasero.py
 - If /tmp/brasero.iso already exist then the test fails because a dialog is displayed asking to overwrite that file. Either check the existence of this dialog or remove /tmp/brasero.iso as a precondition of the test.
* General comment about style:
I'm not a style maniac, far from it, but there are some improvements here.
 - Don't mix tabs and spaces for indentation (brasero/brasero_basics.py)
 - I know that spaces are cheap but don't use them between the function name and the args e.g
NO: brasero = ooldtp.context (self.name)
YES: brasero = ooldtp.context(self.name)

NO: brasero.getchild (self.BTN_BURN).click ()
YES: brasero.getchild(self.BTN_BURN).click()

More infos at http://www.python.org/dev/peps/pep-0008/

I'll be happy to review it again after the changes.

review: Needs Fixing

[Pedro Villavicencio (pedro)]

Thanks for the comments!, I've followed those and include the recommendations into the branch, may you please check and tell me if it's ok this time? Thanks in advance!.

[Jean-Baptiste Lallement (jibel)]

review: Approve

=== added directory 'brasero'
=== added file 'brasero/README'
--- brasero/README	1970-01-01 00:00:00 +0000
+++ brasero/README	2010-11-17 14:23:27 +0000
@@ -0,0 +1,16 @@
+BRASERO TESTS
+=============
+
+Safety
+------
+None of these tests touches any configuration or system files. They are safe to run.
+
+Configuration
+-------------
+A file needs to be on the data/ folder in order to burn it, an example image (brasero-test.png) is included with the test.
+
+Available Tests
+---------------
+
+* Brasero Basics:
+  - Burn Data into an ISO file.

=== added file 'brasero/brasero_basics.py'
--- brasero/brasero_basics.py	1970-01-01 00:00:00 +0000
+++ brasero/brasero_basics.py	2010-11-17 14:23:27 +0000
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+import os
+from time import time, gmtime, strftime
+
+from mago.test_suite.brasero import BraseroTestSuite 
+
+class BraseroBasics(BraseroTestSuite):
+    def burn_path_to_iso(self, path_to_burn=None, iso_tmp_path=None):
+    	#Make sure the iso file is not there and if it's remove it.
+    	self.check_iso_and_remove(iso_tmp_path)
+    	
+    	dir_path = os.path.join(self.get_test_dir(), path_to_burn)
+        self.application.burn_path_to_iso(dir_path, iso_tmp_path)
+        #small check to see if the iso was created on the specified directory.
+        if not(os.path.exists(iso_tmp_path)):
+            raise AssertionError, "ISO file was not created."
+
+if __name__ == "__main__":
+    brasero_test =  BraseroBasics()
+    brasero_test.run()

=== added file 'brasero/brasero_basics.xml'
--- brasero/brasero_basics.xml	1970-01-01 00:00:00 +0000
+++ brasero/brasero_basics.xml	2010-11-17 14:23:27 +0000
@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<suite name="Application Basics">
+  <class>brasero_basics.BraseroBasics</class>
+  <description>
+    Tests which verify Brasero basics file functionality.
+  </description>
+  <case name="Burn Data ISO">
+    <method>burn_path_to_iso</method>
+    <description>Test for burning a directory to an ISO file on the disk</description>
+    <args>
+        <path_to_burn>data/</path_to_burn>
+        <iso_tmp_path>/tmp/brasero.iso</iso_tmp_path>
+    </args>
+  </case>
+</suite>

=== added directory 'brasero/data'
=== added file 'brasero/data/brasero-test.png'
Binary files brasero/data/brasero-test.png	1970-01-01 00:00:00 +0000 and brasero/data/brasero-test.png	2010-11-17 14:23:27 +0000 differ
=== added file 'mago/application/brasero.py'
--- mago/application/brasero.py	1970-01-01 00:00:00 +0000
+++ mago/application/brasero.py	2010-11-17 14:23:27 +0000
@@ -0,0 +1,145 @@
+PACKAGE = "mago"
+
+#-*- coding:utf-8 -*-
+"""
+This is the "brasero" module.
+
+This module provides a wrapper for LDTP to make writing Brasero tests easier.
+"""
+import ooldtp
+import ldtp
+import os
+from .main import Application
+from ..gconfwrapper import GConf
+from ..cmd import globals
+import time
+import gettext
+
+gettext.install (True)
+gettext.bindtextdomain (PACKAGE, globals.LOCALE_SHARE)
+gettext.textdomain (PACKAGE)
+t = gettext.translation(PACKAGE, globals.LOCALE_SHARE, fallback = True)
+_ = t.gettext
+
+
+class Brasero(Application):
+    """
+    brasero manages the Brasero application.
+    """
+
+    LAUNCHER = 'brasero'
+    LAUNCHER_ARGS = []
+    WINDOW = 'frmBrasero*'
+    
+    DLG_SELECT_FILES = _('dlgSelectFiles')
+    DLG_LOCATION_FOR = _('dlgLocationforImageFile')
+    DLG_CREATINGIMAGE = _('dlgCreatingImage')
+    BTN_0 = _('btn0')
+    BTN_1 = _('btn1')
+    BTN_2 = _('btn2')
+    BTN_3 = _('btn3')
+    BTN_4 = _('btn4')
+    BTN_ADD = _('btnAdd')
+    BTN_ADD1 = _('btnAdd1')
+    BTN_ADD2 = _('btnAdd2')
+    BTN_BURN = _('btnBurn*')
+    BTN_CLOSE = _('btnClose')
+    BTN_CREATEFOLDER = _('btnCreateFolder')
+    BTN_CREATEIMAGE = _('btnCreateImage')
+    BTN_DOWNPATH = _('btnDownPath')
+    BTN_EMPTYPROJECT = _('btnEmptyProject')
+    BTN_REMOVE = _('btnRemove')
+    BTN_REMOVE1 = _('btnRemove1')
+    BTN_REMOVE2 = _('btnRemove2')
+    BTN_UPPATH = _('btnUpPath')
+    BTN_ZOOMIN = _('btnZoomIn')
+    BTN_ZOOMOUT = _('btnZoomOut')
+    BTN_TYPE_A_FILENAME = _('btnTypeafilename')
+    MNU_ABOUT = _('mnuAbout')
+    MNU_ADDFILES = _('mnuAddFiles')
+    MNU_ALLFILES = _('mnuAllfiles')
+    MNU_AUDIOFILES = _('mnuAudiofiles')
+    MNU_BLANK___ = _('mnuBlank...')
+    MNU_BROWSETHEFILESYSTEM = _('mnuBrowsethefilesystem')
+    MNU_BURNIMAGE___ = _('mnuBurnImage...')
+    MNU_BURN___ = _('mnuBurn...')
+    MNU_CHECKINTEGRITY___ = _('mnuCheckIntegrity...')
+    MNU_CONTENTS = _('mnuContents')
+    MNU_COPYDISC___ = _('mnuCopyDisc...')
+    MNU_COVEREDITOR = _('mnuCoverEditor')
+    MNU_DISPLAYPLAYLISTSANDTHEIRCONTENTS = _('mnuDisplayplaylistsandtheircontents')
+    MNU_EJECT = _('mnuEject')
+    MNU_EMPTY = _('mnuEmpty')
+    MNU_EMPTY1 = _('mnuEmpty1')
+    MNU_EMPTY2 = _('mnuEmpty2')
+    MNU_EMPTY3 = _('mnuEmpty3')
+    MNU_EMPTY4 = _('mnuEmpty4')
+    MNU_EMPTY5 = _('mnuEmpty5')
+    MNU_EMPTYPROJECT = _('mnuEmptyProject')
+    MNU_GETHELPONLINE = _('mnuGetHelpOnline')
+    MNU_IMAGEFILE = _('mnuImageFile')
+    MNU_IMAGEFILES = _('mnuImagefiles')
+    MNU_MOVIES = _('mnuMovies')
+    MNU_NEWAUDIOPROJECT = _('mnuNewAudioProject')
+    MNU_NEWDATAPROJECT = _('mnuNewDataProject')
+    MNU_NEWVIDEOPROJECT = _('mnuNewVideoProject')
+    MNU_NOITEMSFOUND = _('mnuNoitemsfound')
+    MNU_OPEN___ = _('mnuOpen...')
+    MNU_PLUGINS = _('mnuPlugins')
+    MNU_QUIT = _('mnuQuit')
+    MNU_REMOVEFILES = _('mnuRemoveFiles')
+    MNU_REPORTAPROBLEM = _('mnuReportaProblem')
+    MNU_SAVE = _('mnuSave')
+    MNU_SAVEAS___ = _('mnuSaveAs...')
+    MNU_TRANSLATETHISAPPLICATION = _('mnuTranslateThisApplication')
+    TXT_0 = _('txt0')
+    TXT_1 = _('txt1')
+    TXT_LOCATION = _('txtLocation')
+    TXT_NAME = _('txtName')
+
+    def burn_path_to_iso(self, path_to_burn, iso_tmp_path):
+        brasero = ooldtp.context(self.name)
+
+        # Click on the new data project menu item
+        brasero.getchild(self.MNU_NEWDATAPROJECT).selectmenuitem()
+        ldtp.wait(2)
+        # Click on the Add Files button
+        brasero.getchild(self.BTN_ADD).click()
+        ldtp.wait(2)
+        #Select the files with the path previously assigned on the xml file. (data/)
+        if (ldtp.guiexist(self.DLG_SELECT_FILES)):
+           selectFiles = ooldtp.context(self.DLG_SELECT_FILES)
+           if not (selectFiles.getchild(self.TXT_LOCATION)):
+              ldtp.generatekeyevent('<ctrl>l')
+           textLocation = selectFiles.getchild(self.TXT_LOCATION)
+           textLocation.settextvalue(path_to_burn)
+           ldtp.generatekeyevent('<return>')
+        ldtp.wait(2)
+        # Go back to Brasero window and click on Burn.
+        ldtp.waittillguiexist(self.WINDOW)
+        brasero.getchild(self.BTN_BURN).click()
+        
+        # wait for the dialog and enter the tmp path for the ISO previously assigned on the xml file.
+        ldtp.waittillguiexist(self.DLG_LOCATION_FOR)
+        
+        if (ldtp.guiexist(self.DLG_LOCATION_FOR)):
+            location = ooldtp.context(self.DLG_LOCATION_FOR)
+            textISO = location.getchild(self.TXT_NAME)
+            textISO.settextvalue(iso_tmp_path)
+            if (location.getchild(self.BTN_CREATEIMAGE)):
+                location.getchild(self.BTN_CREATEIMAGE).click()
+            else:
+                ldtp.generatekeyevent('<return>')
+        else:
+            ldtp.generatekeyevent('<return>')
+        
+        #Create the image and wait for the last dialog.
+        ldtp.waittillguiexist(self.DLG_CREATINGIMAGE)
+        creatingImage = ooldtp.context(self.DLG_CREATINGIMAGE)
+        #Wait till the Close button is available, during the burn process only a Cancel button is shown to the user.
+        ldtp.waittillguiexist(self.DLG_CREATINGIMAGE, self.BTN_CLOSE)
+        creatingImage.getchild(self.BTN_CLOSE).click()
+        ldtp.waittillguiexist(self.WINDOW)
+        
+    def __init__(self):
+        Application.__init__(self)

=== added file 'mago/test_suite/brasero.py'
--- mago/test_suite/brasero.py	1970-01-01 00:00:00 +0000
+++ mago/test_suite/brasero.py	2010-11-17 14:23:27 +0000
@@ -0,0 +1,32 @@
+"""
+This module contains the definition of the test suite for Brasero testing.
+"""
+import ldtp, ooldtp
+import os
+from .main import SingleApplicationTestSuite
+from ..application.brasero import Application, Brasero
+
+class BraseroTestSuite(SingleApplicationTestSuite):
+    """
+    Default test suite for Brasero
+    """
+    APPLICATION_FACTORY = Brasero
+    
+    def check_iso_and_remove (self, path=None):
+        if (os.path.exists(path)):
+            try:
+                os.remove(path)
+            except OSError, error:
+                raise AssertionError, ("could not remove %s, %s" % (path, error))
+
+    def setup(self):
+        self.application.open()
+
+    def teardown(self):
+        self.application.close()
+
+    def cleanup(self):
+        #delete the iso if it's present in the tmp dir.
+        ##TODO: grab the variable from the brasero_basics.xml
+        iso_file = '/tmp/brasero.iso'
+        self.check_iso_and_remove(iso_file)