Merge lp:~pedro.baeza/partner-contact-management/7.0-base_location-view_fix into lp:~partner-contact-core-editors/partner-contact-management/7.0

Proposed by Pedro Manuel Baeza
Status: Merged
Merged at revision: 23
Proposed branch: lp:~pedro.baeza/partner-contact-management/7.0-base_location-view_fix
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 18 lines (+4/-2)
1 file modified
base_location/partner_view.xml (+4/-2)
To merge this branch: bzr merge lp:~pedro.baeza/partner-contact-management/7.0-base_location-view_fix
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Guewen Baconnier @ Camptocamp code review, no test Approve
Review via email: mp+177874@code.launchpad.net

Description of the change

There's a problem in parent form when the company country is filled, that hides the city autocompletion field. I don't know why exactly, but I suppose that is due to "partner_address" class that modifies partner view, but there's an easy solution changing the replace position from before to after and the field from city to street2.

I have also added an invisible attribute to hide the autocompletion field when the partner is a contact using parent address.

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Anyone more can review this MP or do I proceed with merge?

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I'll merge it (submitters are not supposed to merge their own work)

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Ah, OK, thank you very much for the clarification.

Regards.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_location/partner_view.xml'
2--- base_location/partner_view.xml 2013-06-07 13:57:09 +0000
3+++ base_location/partner_view.xml 2013-07-31 15:19:10 +0000
4@@ -6,10 +6,12 @@
5 <field name="model">res.partner</field>
6 <field name="inherit_id" ref="base.view_partner_form"/>
7 <field name="arch" type="xml">
8- <field name="city" position="before">
9+ <field name="street2" position="after">
10 <field name="zip_id"
11 on_change="onchange_zip_id(zip_id)"
12- placeholder="City completion"/>
13+ placeholder="City completion"
14+ attrs="{'invisible': [('use_parent_address','=',True)]}"
15+ />
16 </field>
17 </field>
18 </record>

Subscribers

People subscribed via source and target branches

to status/vote changes: