Code review comment for lp:~pedro.baeza/openobject-addons/7.0-updated_l10n_es

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

On 03/24/2013 04:36 PM, Pedro Manuel Baeza wrote:
> - I changed description because I copied/pasted the one from openerp-spain
> repository, but I didn't know that it would break RST. I can restore the
> original one. Can you point me to a explanation for making RST compliant
> texts?

You can start with this guide: http://sphinx-doc.org/rest.html#rst-primer

> Another thing I take the opportunity to ask you: how can I export
> correctly this terms (module title, module description) and so on for
> translation?

You don't need to do anything, we handle the export of translations
automatically in the official addons. But if you want to test it yourself you
need to use the translation export wizard to export the `base` module.
(Module info translations are in `base` otherwise they would not be loaded when
module is not installed yet!)

 > - I put "noupdate" flag to 0 because I discovered some
> incorrect terms in account names (for example, "Inmobilizado" instead of
> "Inmovilizado"). As you have said, these are only templates, so it doesn't
> reflect in generated charts of accounts, but there are two interesting
> applications to renew template data: a) new generated charts of accounts
> have correct data; and b) with account_chart_update module, all previously
> generated charts of accounts can update their accounts names.

Thanks for the explanation. I don't think it's really safe to use
`account_chart_update` in all cases but if users want to have that option, we
should not prevent it. Changing noupdate to 0 should not break anything in the
normal situation, so why not.

 > Another thing I have forgotten: we - at Spanish localization team - are
 > working in a new chart of accounts template for associations, and we have
 > pretty finished it, so I want to include it in this merge proposal.
 >
 > Please wait a few days for this to come to make complete review.

Sure

« Back to merge proposal