Merge lp:~pedro.baeza/openobject-addons/7.0-bug-1253701 into lp:openobject-addons/7.0

Proposed by Pedro Manuel Baeza
Status: Rejected
Rejected by: Martin Trigaux (OpenERP)
Proposed branch: lp:~pedro.baeza/openobject-addons/7.0-bug-1253701
Merge into: lp:openobject-addons/7.0
Diff against target: 31 lines (+7/-7)
1 file modified
mrp/security/mrp_security.xml (+7/-7)
To merge this branch: bzr merge lp:~pedro.baeza/openobject-addons/7.0-bug-1253701
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) (community) Disapprove
Raphaël Valyi - http://www.akretion.com (community) Approve
Review via email: mp+196168@code.launchpad.net

Description of the change

Branch to fix bug 1253701.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I have put it on noupdate=0 section to allow to update users that has already installed the module.

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

LGTM

review: Approve
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Hello Pedro,

As discussed on the bug report, we can not accept this in standard. I will reject this merge then.

Thank you for your understanding

review: Disapprove
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Martin,

As commented on the bug, please reconsider it.

Regards.

Unmerged revisions

9630. By Pedro Manuel Baeza

[FIX] mrp: mrp.bom multi-company rule

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mrp/security/mrp_security.xml'
2--- mrp/security/mrp_security.xml 2012-07-13 17:08:38 +0000
3+++ mrp/security/mrp_security.xml 2013-11-21 17:09:53 +0000
4@@ -23,6 +23,13 @@
5 <field eval="[(6,0,[ref('group_mrp_manager')])]" name="groups_id"/>
6 </record>
7
8+ <record model="ir.rule" id="mrp_bom_rule">
9+ <field name="name">mrp_bom multi-company</field>
10+ <field name="model_id" search="[('model','=','mrp.bom')]" model="ir.model"/>
11+ <field name="global" eval="True"/>
12+ <field name="domain_force">['|','|',('company_id.child_ids','child_of',[user.company_id.id]),('company_id','child_of',[user.company_id.id]),('company_id','=',False)]</field>
13+ </record>
14+
15 </data>
16 <data noupdate="1">
17 <!-- Multi -->
18@@ -40,13 +47,6 @@
19 <field name="domain_force">['|',('company_id','child_of',[user.company_id.id]),('company_id','=',False)]</field>
20 </record>
21
22- <record model="ir.rule" id="mrp_bom_rule">
23- <field name="name">mrp_bom multi-company</field>
24- <field name="model_id" search="[('model','=','mrp.bom')]" model="ir.model"/>
25- <field name="global" eval="True"/>
26- <field name="domain_force">['|',('company_id','child_of',[user.company_id.id]),('company_id','=',False)]</field>
27- </record>
28-
29 <record model="ir.rule" id="mrp_routing_rule">
30 <field name="name">mrp_routing multi-company</field>
31 <field name="model_id" search="[('model','=','mrp.routing')]" model="ir.model"/>