Merge lp:~pedro.baeza/ocb-addons/7.0-bug-1173102 into lp:ocb-addons

[Pedro Manuel Baeza]

[FIX] account: Problem rounding taxes when taxes are included in price.

See lp:1173102 for more details.

[Holger Brunn (Therp) (hbrunn)]

This looks to me like someone calls _compute with the wrong precision. I think http://bazaar.launchpad.net/~ocb/ocb-addons/7.0/view/head:/account/account.py#L2189 is the culprit. Shouldn't we rather fix it there instead of ignoring the precision we get passed in _compute?

review: Needs Information (code review)

[Pedro Manuel Baeza (pedro.baeza)]

I have only copied the solution provided by OpenERP S. A. on trunk, testing that it's working on v7, but without checking the source of the problem. Do you think it can be more generic patching what you say?

Regards.

[Holger Brunn (Therp) (hbrunn)]

I do think changing it where I wrote is the better fix, as it seems quite arbitrary to me to increase rounding precision there

[Pedro Manuel Baeza (pedro.baeza)]

It's solved on upstream.

Unmerged revisions

9920. By Pedro Manuel Baeza on 2014-02-12

[FIX] account: Problem rounding taxes when taxes are included in price.

=== modified file 'account/account.py'
--- account/account.py	2014-01-10 13:38:31 +0000
+++ account/account.py	2014-02-12 08:29:35 +0000
@@ -2322,8 +2322,7 @@
             tax = {'name':'', 'amount':0.0, 'account_collected_id':1, 'account_paid_id':2}
             one tax for each tax id in IDS and their children
         """
-        if not precision:
-            precision = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
+        precision = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
         res = self._unit_compute_inv(cr, uid, taxes, price_unit, product, partner=None)
         total = 0.0
         for r in res: