Merge lp:~pedro.baeza/banking-addons/bank-statement-reconcile-7.0-base_completion_imp into lp:banking-addons/bank-statement-reconcile-70

Proposed by Pedro Manuel Baeza
Status: Rejected
Rejected by: Pedro Manuel Baeza
Proposed branch: lp:~pedro.baeza/banking-addons/bank-statement-reconcile-7.0-base_completion_imp
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 23 lines (+5/-1)
1 file modified
account_statement_base_completion/statement.py (+5/-1)
To merge this branch: bzr merge lp:~pedro.baeza/banking-addons/bank-statement-reconcile-7.0-base_completion_imp
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp code review, no tests Approve
Review via email: mp+222356@code.launchpad.net

Description of the change

[IMP] account_statement_base_completion: Overridable method for get completion rules.

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

LGTM

review: Approve (code review, no tests)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Unmerged revisions

157. By Pedro Manuel Baeza

[IMP] account_statement_base_completion: Overridable method for get completion rules.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_base_completion/statement.py'
2--- account_statement_base_completion/statement.py 2014-05-14 15:45:12 +0000
3+++ account_statement_base_completion/statement.py 2014-06-06 15:28:51 +0000
4@@ -139,6 +139,10 @@
5 ('get_from_label_and_partner_field', 'From line label (based on partner field)'),
6 ('get_from_label_and_partner_name', 'From line label (based on partner name)')]
7
8+ def __get_functions(self, cr, uid, context=None):
9+ """Internal method. Do not override."""
10+ return self._get_functions(cr, uid, context=context)
11+
12 _columns = {
13 'sequence': fields.integer('Sequence', help="Lower means parsed first."),
14 'name': fields.char('Name', size=128),
15@@ -146,7 +150,7 @@
16 'account.statement.profile',
17 rel='as_rul_st_prof_rel',
18 string='Related statement profiles'),
19- 'function_to_call': fields.selection(_get_functions, 'Method'),
20+ 'function_to_call': fields.selection(__get_functions, 'Method'),
21 }
22
23 def _find_invoice(self, cr, uid, st_line, inv_type, context=None):

Subscribers

People subscribed via source and target branches