Code review comment for lp:~pedro.baeza/account-payment/6.1-set_done_optimization

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> Hi, Stefan, I'm using the same code for this task that was previously set, but
> I don't know if there is any reason to make that on first place. Making a
> quick scan over post method on account.move model, I see that two tasks are
> performed:
>
> - An integrity check. This is maybe redundant or useless, and bad for
> performance when you do big moves (I have some environments with payment
> orders with 3k lines).
> - A sequence number assignation. This makes me wonder how the number is
> assigned in this code.
>
> Tomorrow I will check deeply.
>
> Thanks for the tip.
>
> Regards.

Hi, could you check?

« Back to merge proposal