Account - Financial Tools

Merge lp:~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix into lp:~account-core-editors/account-financial-tools/7.0

  1. 7.0-account_invoice_currency-fix
  2. Merge into 7.0
Proposed by Pedro Manuel Baeza
Status: Merged
Merged at revision: 186
Proposed branch: lp:~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix
Merge into: lp:~account-core-editors/account-financial-tools/7.0
Diff against target: 48 lines (+8/-10)
1 file modified
account_invoice_currency/account_invoice_view.xml (+8/-10)
To merge this branch: bzr merge lp:~pedro.baeza/account-financial-tools/7.0-account_invoice_currency-fix
Reviewer Review Type Date Requested Status
Nicolas Bessi - Camptocamp (community) Approve
Ana Juaristi Olalde (community) code review Approve
Omar (Pexego) code review Approve
Yannick Vaucher @ Camptocamp code review, no test Approve
Review via email: mp+211845@code.launchpad.net

Description of the change

[FIX] account_invoice_currency: Fix indentation on XML file
[FIX] account_invoice_currency: Remove type attribute on XML views

This is for avoiding warnings on log.

To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Omar (Pexego) (omar7r) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

LGTM

Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_invoice_currency/account_invoice_view.xml'
2--- account_invoice_currency/account_invoice_view.xml 2013-12-23 17:21:34 +0000
3+++ account_invoice_currency/account_invoice_view.xml 2014-03-19 23:46:26 +0000
4@@ -3,21 +3,20 @@
5 <data>
6
7 <!-- ###############################################
8- INVOICE INHERITANCE
9+ INVOICE INHERITANCE
10 ############################################### -->
11
12 <!-- ## Suppliers ## -->
13 <record id="invoice_supplier_company_currency_form" model="ir.ui.view">
14 <field name="name">Account invoice supplier (form) - add company currency</field>
15 <field name="model">account.invoice</field>
16- <field name="type">form</field>
17 <field name="inherit_id" ref="account.invoice_supplier_form"/>
18 <field name="arch" type="xml">
19 <field name="period_id" position="after">
20 <group string="Amounts in company currency">
21- <field name="cc_amount_untaxed"/>
22- <field name="cc_amount_tax"/>
23- <field name="cc_amount_total"/>
24+ <field name="cc_amount_untaxed"/>
25+ <field name="cc_amount_tax"/>
26+ <field name="cc_amount_total"/>
27 </group>
28 </field>
29 </field>
30@@ -27,14 +26,13 @@
31 <record id="invoice_company_currency_form" model="ir.ui.view">
32 <field name="name">Account invoice (form) - add company currency</field>
33 <field name="model">account.invoice</field>
34- <field name="type">form</field>
35 <field name="inherit_id" ref="account.invoice_form"/>
36 <field name="arch" type="xml">
37 <field name="move_id" position="after">
38- <group string="Amounts in company currency">
39- <field name="cc_amount_untaxed"/>
40- <field name="cc_amount_tax"/>
41- <field name="cc_amount_total"/>
42+ <group string="Amounts in company currency">
43+ <field name="cc_amount_untaxed"/>
44+ <field name="cc_amount_tax"/>
45+ <field name="cc_amount_total"/>
46 </group>
47 </field>
48 </field>

Subscribers

People subscribed via source and target branches