Merge lp:~peco/ubuntu/maverick/sessioninstaller/newfix-for-793396 into lp:ubuntu/maverick/sessioninstaller

Proposed by Peco
Status: Needs review
Proposed branch: lp:~peco/ubuntu/maverick/sessioninstaller/newfix-for-793396
Merge into: lp:ubuntu/maverick/sessioninstaller
Diff against target: 47 lines (+17/-2)
3 files modified
README (+1/-1)
debian/changelog (+15/-0)
session-installer (+1/-1)
To merge this branch: bzr merge lp:~peco/ubuntu/maverick/sessioninstaller/newfix-for-793396
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Fixing
Review via email: mp+66556@code.launchpad.net

Description of the change

Two typos (session-installer and README file).
See diff file attached to the LP: #793396

To post a comment you must log in.
Revision history for this message
Peco (peco) wrote :

The bug LP # 793396 is related to two typos.
I fixed first the one described on the formal description of the bug (fix-for-793396) and then the second typo at the README file (new-fix-for-793396)

Revision history for this message
Luke Yelavich (themuso) wrote :

Thanks for your work. It appears your branch has 2 changelog entries. Could you plesae merge the entries into 1? Please also target the fix to maverick-proposed, should you feel its worthwhile pushing a fix to maverick updates.

I'd also advise the version to be 0.20+bzr115-0ubuntu1.1, as this makes sure the version doesn't conflict with any later package versions of sessioninstaller in other Ubuntu releases.

Thanks again.

review: Needs Fixing
Revision history for this message
Peco (peco) wrote :

Sorry for the mistakes. This is my first time and I'm using these easy fixes in order to learn.
I redid the whole process: download the sources (bzr), fix them, doc (dch -i) and commit (locally, debcommit).

But now I've two doubts:

1) How can I target maverick-proposed?.

Instead of:
bzr push lp:~peco/ubuntu/maverick/sessioninstaller/fix-for-793396
I should do:
bzr push lp:~peco/ubuntu/maverick-proposed/sessioninstaller/fix-for-793396

2) How can I set the version to 0.20+bzr115-0ubuntu1.1?
Last time it was automatically defined by bzr

Thanks in advance!

Unmerged revisions

8. By Peco

Minor typo at README file: "GStreamer codecs" instead of
"GSreamer codecs". (LP: #793396, see diff file)

7. By Peco

A minor typo in the description of the package, as it said
"APT based installer using PackgeKit's session DBus API".
The missing 'a' from PackageKit's was added. (LP: #793396)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2010-05-27 10:03:53 +0000
3+++ README 2011-07-01 07:56:24 +0000
4@@ -1,7 +1,7 @@
5 INTRODUCTION
6
7 Sessioninstaller allows applications to easily install additional software
8-(e.g. extensions or GSreamer codecs), to uninstall files and to perform simple
9+(e.g. extensions or GStreamer codecs), to uninstall files and to perform simple
10 software status queries by implementing the distribution neutral D-Bus session
11 interface of PackageKit.
12
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2010-09-24 10:50:55 +0000
16+++ debian/changelog 2011-07-01 07:56:24 +0000
17@@ -1,3 +1,18 @@
18+sessioninstaller (0.20+bzr115-0ubuntu3) maverick; urgency=low
19+
20+ * Minor typo at README file: "GStreamer codecs" instead of
21+ "GSreamer codecs". (LP: #793396, see diff file)
22+
23+ -- Juan José 'Peco' San Martín <peco@microbotica.es> Fri, 01 Jul 2011 09:17:34 +0200
24+
25+sessioninstaller (0.20+bzr115-0ubuntu2) maverick; urgency=low
26+
27+ * A minor typo in the description of the package, as it said
28+ "APT based installer using PackgeKit's session DBus API".
29+ The missing 'a' from PackageKit's was added. (LP: #793396)
30+
31+ -- Juan José 'Peco' San Martín <peco@microbotica.es> Thu, 30 Jun 2011 22:01:04 +0200
32+
33 sessioninstaller (0.20+bzr115-0ubuntu1) maverick; urgency=low
34
35 * New bzr version that use the command-not-found database to
36
37=== modified file 'session-installer'
38--- session-installer 2010-05-27 10:03:53 +0000
39+++ session-installer 2011-07-01 07:56:24 +0000
40@@ -1,6 +1,6 @@
41 #!/usr/bin/env python
42 # -*- coding: utf-8 -*-
43-"""sessioninstaller - APT based installer using PackgeKit's session DBus API"""
44+"""sessioninstaller - APT based installer using PackageKit's session DBus API"""
45 # Copyright (C) 2008-2009 Sebastian Heinlein <devel@glatzor.de>
46 #
47 # This program is free software; you can redistribute it and/or modify

Subscribers

People subscribed via source and target branches

to all changes: