Merge lp:~pconnell/endroid/remote into lp:endroid

Proposed by Phil Connell
Status: Merged
Approved by: ChrisD
Approved revision: no longer in the source branch.
Merged at revision: 97
Proposed branch: lp:~pconnell/endroid/remote
Merge into: lp:endroid
Diff against target: 39 lines (+8/-2)
3 files modified
bin/endroid_remote (+1/-1)
debian/changelog (+6/-0)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~pconnell/endroid/remote
Reviewer Review Type Date Requested Status
ChrisD Approve
Review via email: mp+237943@code.launchpad.net

Commit message

Fix "endroid_remote watch" and tag 1.4.5 release.

Description of the change

Fix endroid_remote watch and tag 1.4.5 release.

Failure seen with 1.4.4:

$ cat /proc/cpuinfo | endroid_remote watch "model name"
processor : 0
Traceback (most recent call last):
  File "/auto/ensoft/bin/endroid_remote", line 175, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/auto/ensoft/bin/endroid_remote", line 167, in main
    subcmd_obj.event_loop()
  File "/auto/ensoft/bin/endroid_remote", line 83, in event_loop
    if self._re.search(line):
AttributeError: 'str' object has no attribute 'search'

To post a comment you must log in.
Revision history for this message
ChrisD (gingerchris) wrote :

Thanks!

review: Approve
lp:~pconnell/endroid/remote updated
97. By Phil Connell <email address hidden>

Fix "endroid_remote watch" and tag 1.4.5 release.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/endroid_remote'
2--- bin/endroid_remote 2014-09-15 11:23:47 +0000
3+++ bin/endroid_remote 2014-10-10 11:21:02 +0000
4@@ -72,7 +72,7 @@
5 "lines will be sent to EnDroid")
6
7 def process_args(self, args):
8- self._re = args.regex
9+ self._re = re.compile(args.regex)
10
11 def event_loop(self):
12 line = sys.stdin.readline()
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2014-10-03 10:17:08 +0000
16+++ debian/changelog 2014-10-10 11:21:02 +0000
17@@ -1,3 +1,9 @@
18+endroid (1.4.5) trusty; urgency=medium
19+
20+ * Fix endroid_remote watch.
21+
22+ -- Phil Connell <phil.connell@ensoft.co.uk> Fri, 10 Oct 2014 12:18:00 +0100
23+
24 endroid (1.4.4) trusty; urgency=medium
25
26 * Fix MUC behaviour for servers that do not allow nickname changes
27
28=== modified file 'setup.py'
29--- setup.py 2014-10-03 11:00:53 +0000
30+++ setup.py 2014-10-10 11:21:02 +0000
31@@ -24,7 +24,7 @@
32
33
34 setup(name='endroid',
35- version="1.4.4",
36+ version="1.4.5",
37 description='EnDroid: a modular XMPP bot',
38 url='http://open.ensoft.co.uk/EnDroid',
39 packages=[

Subscribers

People subscribed via source and target branches