Merge lp:~pcabido/gtg/hackathon into lp:~gtg/gtg/old-trunk
Proposed by
Paulo Cabido
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1049 | ||||||||
Proposed branch: | lp:~pcabido/gtg/hackathon | ||||||||
Merge into: | lp:~gtg/gtg/old-trunk | ||||||||
Diff against target: |
194 lines (+58/-25) 5 files modified
GTG/gtk/preferences.py (+29/-11) GTG/plugins/bugzilla/bug.py (+20/-10) GTG/plugins/bugzilla/bugzilla.py (+3/-3) GTG/plugins/bugzilla/server.py (+5/-0) GTG/plugins/notification_area/notification_area.py (+1/-1) |
||||||||
To merge this branch: | bzr merge lp:~pcabido/gtg/hackathon | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Izidor Matušov | code | Approve | |
Review via email: mp+83483@code.launchpad.net |
Description of the change
This branch has some bug fixes including two critical bugs: bug #577111 and fixed bug #565572
To post a comment you must log in.
Hi,
I tried to apply your change about bugzilla plugin. I've installed
sudo apt-get install python-bugz
I've run (the small unittest)
python GTG/plugins/ bugzilla/ bug.py
and it does not work with your change... However, if I run the old version, I get a different traceback bugzilla/ bug.py" , line 46, in <module> bugzilla. gnome.org', '598354'), bugzilla/ bug.py" , line 21, in __init__ python2. 7/dist- packages/ bugz.py" , line 842, in get parse(fd, parser) python2. 7/xml/etree/ ElementTree. py", line 1177, in parse parse(source, parser) python2. 7/xml/etree/ ElementTree. py", line 653, in parse feed(data) python2. 7/xml/etree/ ElementTree. py", line 1623, in feed XMLTreeBuilder' object has no attribute '_error'
<traceback>
Traceback (most recent call last):
File "GTG/plugins/
for bug in [Bug('http://
File "GTG/plugins/
self.bug = Bugz(base).get(nb)
File "/usr/lib/
etree = ElementTree.
File "/usr/lib/
tree.
File "/usr/lib/
parser.
File "/usr/lib/
except self._error, v:
AttributeError: 'ForcedEncoding
</traceback>
I am not sure what is going on there, could you investigate it, please?
I can confirm that those bugs are solved in this branch.
Could please also remove on_plugin_ about_close_ foo() method?
Thanks for your contribution, setting to Needs Fixing because of that bugzilla plugin.