Code review comment for lp:~pbeaman/akiban-persistit/fix-wait-for-durability

Revision history for this message
Nathan Williams (nwilliams) wrote :

This look pretty good.

Just a few questions:
IOMeter#DEFAULT_QUIESCENT_IO_THRESHOLD was increased by 1000. The usage of it in JournalManager was also scaled by 1024. I'm not entirely what that is used for, can you elaborate?

JournalManager#selectForCopy() went from asserting the pageNodes were valid to checking it. Can invalid nodes be in the list now?

Minor:
Probably just my preference, but constants with units in the name make one less thing to check (new intervals in CleanupManager).

review: Needs Information

« Back to merge proposal