Code review comment for lp:~pbeaman/akiban-persistit/buffer-pool-warmup-sorted

Revision history for this message
Nathan Williams (nwilliams) wrote :

Talked with Peter about this offline and the points I raised were what he alluded to in the merge description.

- Writing 1M records, non-transactionally, is a sub-second activity
- Start-up reading of the pages will be the slow part, perhaps minutes
- There are progress messages and this is the tradeoff to not have it spread out over hours
- And most importantly, this defaults to OFF

Given all that, putting this in is low risk and timing on large pools can be done soon^TM.

review: Approve

« Back to merge proposal