Code review comment for lp:~pbeaman/akiban-persistit/buffer-pool-warmup-sorted

Revision history for this message
Nathan Williams (nwilliams) wrote :

The diff on LP is still wonky, but I checked out locally and everything is fine.

Changes look good, just a few questions below.

The inventory is taken in the checkpoint thread. How does the run time of the inventory scale with the size of the pool? You mentioned a 25K test, but the 1M is also a realistic size (even in our nightlies).

Along the same lines, have you tried this under any load?

Lastly, it is also done on close(). If this takes even in the 10s of seconds, we might want add an option for that.

review: Needs Information

« Back to merge proposal