Merge lp:~pawciobiel/testdrive/1171045-fix-typo-parallels into lp:testdrive

Proposed by pawciobiel on 2014-09-13
Status: Merged
Merged at revision: 450
Proposed branch: lp:~pawciobiel/testdrive/1171045-fix-typo-parallels
Merge into: lp:testdrive
Diff against target: 33 lines (+3/-3)
2 files modified
bin/testdrive (+2/-2)
bin/testdrive-gtk (+1/-1)
To merge this branch: bzr merge lp:~pawciobiel/testdrive/1171045-fix-typo-parallels
Reviewer Review Type Date Requested Status
Andres Rodriguez 2014-09-13 Approve on 2015-07-04
Review via email: mp+234566@code.launchpad.net

Description of the change

fix typo bug lp:1171045

To post a comment you must log in.
pawciobiel (pawciobiel) wrote :

I thought for now we could just fix the typo here quickly and drop support for "parallels" in some other ticket, what do you reckon?

Jackson Doak (noskcaj) wrote :

Since no one's actively working on testdrive, just bugfix stuff, it's very
appreciated that you made the fix.

On Sat, Sep 13, 2014 at 8:24 PM, pawciobiel <email address hidden> wrote:

> I thought for now we could just fix the typo here quickly and drop support
> for "parallels" in some other ticket, what do you reckon?
> --
>
> https://code.launchpad.net/~pawciobiel/testdrive/1171045-fix-typo-parallels/+merge/234566
> Your team testdrive is requested to review the proposed merge of
> lp:~pawciobiel/testdrive/1171045-fix-typo-parallels into lp:testdrive.
>

pawciobiel (pawciobiel) wrote :

cheers!

Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/testdrive'
2--- bin/testdrive 2013-10-24 02:11:50 +0000
3+++ bin/testdrive 2014-09-13 10:22:38 +0000
4@@ -264,7 +264,7 @@
5 logger.info(_("Using KVM for virtual machine hosting..."));
6 elif td.VIRT == "virtualbox":
7 logger.info(_("Using VirtualBox for virtual machine hosting..."))
8- elif td.VIRT == "paralels":
9+ elif td.VIRT == "parallels":
10 logger.info(_("Using Parallels Desktop for virtual machine hosting..."))
11
12 ##########################################
13@@ -392,7 +392,7 @@
14 virt = kvm.KVM(td)
15 if td.VIRT == "virtualbox":
16 virt = virtualbox.VBox(td)
17- if td.VIRT == "paralels":
18+ if td.VIRT == "parallels":
19 virt = parallels.Parallels(td)
20
21 ###################
22
23=== modified file 'bin/testdrive-gtk'
24--- bin/testdrive-gtk 2013-11-17 08:19:27 +0000
25+++ bin/testdrive-gtk 2014-09-13 10:22:38 +0000
26@@ -739,7 +739,7 @@
27 if self.td.VIRT == "virtualbox":
28 logging.info(_("Using VirtualBox for virtual machine hosting..."))
29 virt = virtualbox.VBox(self.td)
30- if self.td.VIRT == "paralels":
31+ if self.td.VIRT == "parallels":
32 logging.info(_("Using Parallels Desktop for virtual machine hosting..."))
33 virt = parallels.Parallels(self.td)
34

Subscribers

People subscribed via source and target branches