Merge lp:~paultag/rinput/sasl-config into lp:rinput/debian

Proposed by Chase Douglas
Status: Merged
Merge reported by: Chase Douglas
Merged at revision: not available
Proposed branch: lp:~paultag/rinput/sasl-config
Merge into: lp:rinput/debian
Diff against target: 58 lines (+41/-0)
3 files modified
debian/changelog (+6/-0)
debian/config (+16/-0)
debian/templates (+19/-0)
To merge this branch: bzr merge lp:~paultag/rinput/sasl-config
Reviewer Review Type Date Requested Status
Chase Douglas Approve
Review via email: mp+22355@code.launchpad.net

Description of the change

Added SASL default options for the debian directory. Under the hood it runs:

echo $RET | saslpasswd2 -c -u rinput user

where RET is the queried password.

To post a comment you must log in.
Revision history for this message
Chase Douglas (chasedouglas) wrote :

This is about 90% there. Thanks for laying all the ground work! We need to either prompt for both a username and a password, or make it clear that the password is associated with a given default username. I think I prefer the former, and all in one screen (I'm pretty sure this is possible, but maybe not). If we go with the latter, I'd prefer a default username like "rinput" rather than just "user". I think "user" as the username could get confusing.

One other nitpick: why is the template named rinput/passw? If it can be anything, I would choose rinputd/passwd.

Again, thanks a lot for doing this! Not only are you helping me out with rinputd, you're also helping me figure out launchpad :). BTW, if you happen to be swamped with other work I can add the changes myself and merge it in.

review: Needs Fixing
Revision history for this message
Paul Tagliamonte (paultag) wrote :

Haha, I'll take care of getting the rest of this accross the finish line. I just whipped this up in a few spare minutes to get the basic idea there.

I'll get it lined up and set up for ya

I'll rename too, I was worried about klobbering the namespace ( I thought password / passwd was reserved, I was wrong ).

More to come ;)

lp:~paultag/rinput/sasl-config updated
80. By Paul Tagliamonte <tag@Loki>

small changes to fix open issues regarding a merge against mainline.

Revision history for this message
Paul Tagliamonte (paultag) wrote :

Rev 80 pushed. Uses three prompts, one description, one username prompt and one password prompt.

lp:~paultag/rinput/sasl-config updated
81. By Paul Tagliamonte <tag@Loki>

fixing error in policy

Revision history for this message
Chase Douglas (chasedouglas) wrote :

This looks good. I still have some changes I'm going to make, but I'm merging this in now.

Thanks Paul!

review: Approve
Revision history for this message
Paul Tagliamonte (paultag) wrote :

Sure thing!

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-02-25 02:22:14 +0000
3+++ debian/changelog 2010-03-29 13:35:46 +0000
4@@ -1,3 +1,9 @@
5+rinputd (1.0.3-2) UNRELEASED; urgency=low
6+
7+ * Added in the config and templates files.
8+
9+ -- Paul Tagliamonte <paultag@ubuntu.com> Mon, 29 Mar 2010 01:11:00 -0400
10+
11 rinputd (1.0.3-1) unstable; urgency=low
12
13 * Initial package
14
15=== added file 'debian/config'
16--- debian/config 1970-01-01 00:00:00 +0000
17+++ debian/config 2010-03-29 13:35:46 +0000
18@@ -0,0 +1,16 @@
19+#!/bin/bash -e
20+
21+. /usr/share/debconf/confmodule
22+
23+db_input high rinput/about || true
24+db_input high rinput/username || true
25+db_input high rinput/passwd || true
26+
27+db_go
28+
29+db_get rinput/username
30+USER="$RET"
31+db_get rinput/passwd
32+PASS="$RET"
33+
34+echo $PASS | saslpasswd2 -c -u rinput $USER
35
36=== added file 'debian/templates'
37--- debian/templates 1970-01-01 00:00:00 +0000
38+++ debian/templates 2010-03-29 13:35:46 +0000
39@@ -0,0 +1,19 @@
40+Template: rinput/about
41+Type: text
42+Description: Configure the rinputd sasl username and password
43+ The following two prompts will help you set up a new sasl user
44+ account and password. This allows for remote access to this
45+ computer.
46+
47+Template: rinput/username
48+Type: string
49+Description: This is the user account name for the sasl rinputd login.
50+ This has no bearing on the local login, and will not create
51+ a local user account, nor conflict with the local user namespace.
52+
53+Template: rinput/passwd
54+Type: password
55+Description: Password for the rinputd sasl user account.
56+ This password is not related to shell level login, but will allow
57+ control of the keyboard and mouse through the rinputd daemon.
58+

Subscribers

People subscribed via source and target branches