Code review comment for lp:~paulliu/unity8/unity8-fixgenericpreview

Revision history for this message
Michael Zanetti (mzanetti) wrote :

From the design spec: http://i.imgur.com/up8dETX.png

I see we have Preview, Header, Actions, Description and Rating as elements on the preview. Our code is still structured for the old previews and the new elements somehow squeezed into the old structure. I think in the long run this will cause continuous headaches and would vote for properly doing the rework, splitting up DashPreview.qml into exactly those defined fields. Another thing is that the current code still holds id's etc referring to the old structure. For example the id for the area that holds the screenshots (in the design spec called "Preview") is still named headerIcon in the code. This is quite a mess imho.

Also,
This is how it looks in landscape mode http://i.imgur.com/nAknW9T.jpg , while this is how it should look like http://i.imgur.com/uwHyln6.jpg

I guess that's a side effect of not having it structured properly.

review: Needs Fixing

« Back to merge proposal