Merge lp:~paulliu/unity8/preview_title_20140916 into lp:unity8

Proposed by Ying-Chun Liu
Status: Merged
Approved by: Michael Terry
Approved revision: 1264
Merged at revision: 1303
Proposed branch: lp:~paulliu/unity8/preview_title_20140916
Merge into: lp:unity8
Diff against target: 11 lines (+0/-1)
1 file modified
qml/Dash/Previews/PreviewHeader.qml (+0/-1)
To merge this branch: bzr merge lp:~paulliu/unity8/preview_title_20140916
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Terry Approve
Review via email:

Commit message

Remove maxLineCount in preview. (LP: 1328513)

Description of the change

* Are there any related MPs required for this MP to build/function as expected?

 * Did you perform an exploratory manual test run of your code change and any related functionality?

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

 * If you changed the UI, has there been a design review?
Waiting for review.

To post a comment you must log in.
Michael Terry (mterry) wrote :

Approved. As Esti from Design says: "In the preview we should always show the full title with no truncation. From one single line ttles to as many as required."

 * Did you perform an exploratory manual test run of the code change and any related functionality?

 * Did CI run pass? If not, please explain why.
 No, but for unrelated reasons.

review: Approve
1265. By Ying-Chun Liu on 2014-09-19

merge trunk

1266. By Ying-Chun Liu on 2014-09-23

merge trunk

1267. By Ying-Chun Liu on 2014-09-29

merge trunk

Ying-Chun Liu (paulliu) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/Previews/PreviewHeader.qml'
2--- qml/Dash/Previews/PreviewHeader.qml 2014-08-13 10:29:21 +0000
3+++ qml/Dash/Previews/PreviewHeader.qml 2014-09-29 14:08:36 +0000
4@@ -97,7 +97,6 @@
5 font.weight: Font.Normal
6 fontSize: "large"
7 wrapMode: Text.Wrap
8- maximumLineCount: 2
9 color: headerRoot.fontColor
10 text: headerRoot.title
11 }


People subscribed via source and target branches