Merge lp:~paulliu/unity8/lp1383693 into lp:unity8/rtm-14.09

Proposed by Ying-Chun Liu
Status: Rejected
Rejected by: Michał Sawicz
Proposed branch: lp:~paulliu/unity8/lp1383693
Merge into: lp:unity8/rtm-14.09
Diff against target: 12 lines (+1/-1)
1 file modified
qml/Components/EdgeDemo.qml (+1/-1)
To merge this branch: bzr merge lp:~paulliu/unity8/lp1383693
Reviewer Review Type Date Requested Status
Michał Sawicz Needs Resubmitting
Review via email: mp+239579@code.launchpad.net

Commit message

Fix EdgeDemo anchors bug. (LP: #1383693)

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Nothing changed
 * If you changed the UI, has there been a design review?
Nothing changed.

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

If at all, this needs to happen against lp:unity8, we're not landing anything in the rtm branch any more.

review: Needs Resubmitting
Ying-Chun Liu (paulliu) wrote :

lp:unity8 contains this already. Also works good already.
So what to do with the bugs?

Michał Sawicz (saviq) wrote :

Well, trunk did not contain the problem, because the feature I just linked only landed in rtm. But the branch against trunk contains a fix for this.

Unmerged revisions

1365. By Ying-Chun Liu on 2014-10-24

Fix EdgeDemo anchors bug. (LP: #1383693)

1364. By PS Jenkins bot on 2014-10-17

Releasing 8.00+14.10.20141017-0ubuntu1

1363. By kevin gunn on 2014-10-17

update edgedemo to account for new indicators

1362. By PS Jenkins bot on 2014-10-15

Releasing 8.00+14.10.20141015.4~rtm-0ubuntu1

1361. By Albert Astals Cid on 2014-10-15

Reset VerticalJournal until the cardTool settles Fixes: 1381255
Approved by: Michał Sawicz

1360. By Albert Astals Cid on 2014-10-15

CardAttributes: Specify column and row since the gridlayout gets confused sometimes Fixes: 1381092
Approved by: Michał Sawicz

1359. By Antti Kaijanmäki on 2014-10-15

Unlock all modems on boot. Fixes: 1333121
Approved by: Michał Sawicz

1358. By Nick Dedekind on 2014-10-15

Implementation of expandable panel design Fixes: 1368856

1357. By Michael Zanetti on 2014-10-15

Fix lp:1370240 by making stages interactive when a snap decision is dismissed. Fixes: 1370240
Approved by: Michał Sawicz

1356. By Michael Zanetti on 2014-10-15

drop all visual indication of "pinning" Fixes: 1381054
Approved by: Andrea Cimitan

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Components/EdgeDemo.qml'
2--- qml/Components/EdgeDemo.qml 2014-10-17 00:04:35 +0000
3+++ qml/Components/EdgeDemo.qml 2014-10-24 15:36:22 +0000
4@@ -169,7 +169,7 @@
5 "edge": "bottom",
6 "title": i18n.tr("Close"),
7 "text": i18n.tr("Swipe up again to close the settings screen"),
8- "anchors.fill": demo.indicators,
9+ "anchors.fill": demo.indicators.content,
10 });
11 }
12 if (d.bottomEdgeDemo) {

Subscribers

People subscribed via source and target branches

to all changes: