Merge lp:~paulliu/unity8/lp1379384 into lp:unity8

Proposed by Ying-Chun Liu
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1372
Merged at revision: 1451
Proposed branch: lp:~paulliu/unity8/lp1379384
Merge into: lp:unity8
Diff against target: 33 lines (+10/-3)
1 file modified
qml/Shell.qml (+10/-3)
To merge this branch: bzr merge lp:~paulliu/unity8/lp1379384
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Zanetti (community) Approve
Review via email: mp+238986@code.launchpad.net

Commit message

Notifications should be on right side when wide. (LP: 1379384)

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
 * Did you make sure that your branch does not contain spurious tags?
Yes.
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
lp:~paulliu/unity8/lp1379384 updated
1370. By Ying-Chun Liu on 2014-10-31

merge trunk

lp:~paulliu/unity8/lp1379384 updated
1371. By Ying-Chun Liu on 2014-11-10

merge trunk

Michael Zanetti (mzanetti) wrote :

small inline nitpick

review: Needs Fixing
lp:~paulliu/unity8/lp1379384 updated
1372. By Ying-Chun Liu on 2014-11-14

Change to use anchors on narrow and width on wide.

Michael Zanetti (mzanetti) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

waiting, but a previous, very similar version passed fine

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve
lp:~paulliu/unity8/lp1379384 updated
1373. By Ying-Chun Liu on 2014-11-18

merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Shell.qml'
2--- qml/Shell.qml 2014-11-17 13:47:59 +0000
3+++ qml/Shell.qml 2014-11-18 13:03:29 +0000
4@@ -764,19 +764,26 @@
5 margin: units.gu(1)
6
7 y: topmostIsFullscreen ? 0 : panel.panelHeight
8- width: parent.width
9 height: parent.height - (topmostIsFullscreen ? 0 : panel.panelHeight)
10
11 states: [
12 State {
13 name: "narrow"
14 when: overlay.width <= units.gu(60)
15- AnchorChanges { target: notifications; anchors.left: parent.left }
16+ AnchorChanges {
17+ target: notifications
18+ anchors.left: parent.left
19+ anchors.right: parent.right
20+ }
21 },
22 State {
23 name: "wide"
24 when: overlay.width > units.gu(60)
25- AnchorChanges { target: notifications; anchors.left: undefined }
26+ AnchorChanges {
27+ target: notifications
28+ anchors.left: undefined
29+ anchors.right: parent.right
30+ }
31 PropertyChanges { target: notifications; width: units.gu(38) }
32 }
33 ]

Subscribers

People subscribed via source and target branches