According to our coding guidelines, in javascript code you should end statements with ";". Even though that file doesn't follow the guidelines, I think we must start rectifying it by making new code comply.
+++ Components/Carousel.qml 2013-07-16 14:11:33 +0000
@@ -52,6 +52,12 @@ Item {
/// @param itemY is y of the clicked delegate
signal clicked(int index, var delegateItem, real itemY)
+ /// Emitted when the user pressAndHold on an item
+ /// @param index is the index of the clicked item
+ /// @param delegateItem is the clicked component/delegate itself
+ /// @param itemY is y of the clicked delegate
The documentation of the parameters tell about a "clicked item". But the item wasn't clicked (it's a long press).
Some minor stuff
================
According to our coding guidelines, in javascript code you should end statements with ";". Even though that file doesn't follow the guidelines, I think we must start rectifying it by making new code comply.
------- ------- ------- ------- ------- ------- ------- -----
+++ Components/ Carousel. qml 2013-07-16 14:11:33 +0000
@@ -52,6 +52,12 @@ Item {
/// @param itemY is y of the clicked delegate
signal clicked(int index, var delegateItem, real itemY)
+ /// Emitted when the user pressAndHold on an item
+ /// @param index is the index of the clicked item
+ /// @param delegateItem is the clicked component/delegate itself
+ /// @param itemY is y of the clicked delegate
The documentation of the parameters tell about a "clicked item". But the item wasn't clicked (it's a long press).
------- ------- ------- ------- ------- ------- ------- -----
+ /* We're pressAndHold the selected item and
Syntax is not right. Looks like you just copy-pasted and then s/click* /pressAndHold.
Will continue the review tomorrow.