Code review comment for lp:~paulliu/unity/phablet-fake-peoplepreviewdata

Revision history for this message
Albert Astals Cid (aacid) wrote :

But this thing only has getters and almost not setters, maybe you can try to use it in the test? Because i am not seeing right now how it would be useful.

Also, maybe we could use the "real" ./plugins/Unity/peoplepreviewdata.h and you create a fake unity::dash::Preview::Ptr that gives the data? This way we test the peoplepreviewdata class too?

« Back to merge proposal