Code review comment for lp:~paulliu/unity/i18n

12 +find_package(Gettext REQUIRED)

245 +find_package(Gettext REQUIRED)

Duplicated - should be enough to keep it in po/CMakeLists.txt

=====

77 - - Add/update Vcs-Browser, Vcs-Bzr and add a notice to uploaders.
78 + - Add/update Vcs-Browser, Vcs-Bzr and add a notice to uploaders.

There's a bunch of changes to debian/* that should not happen in this MR, and I'm not sure about putting ${} depends at the end, isn't it a convention to keep them at the beginning?

=====

259 +ADD_CUSTOM_TARGET(pot_file ${_all}

the ${_all} seems undefined?

=====

257 + COMMAND ./update-unity-pot

You should use ${CMAKE_CURRENT_SOURCE_DIR} here

=====

286 +#: builddir/install/share/qml-phone-shell/Components/PageHeader.qml:300
...

Builddir should be excluded from pot generation.

=====

362 + --copyright-holder "Canonical Ltd"

Missing dot at the end.

=====

370 +# SOME DESCRIPTIVE TITLE.
371 +# Copyright (C) YEAR Canonical Ltd
372 +# This file is distributed under the same license as the PACKAGE package.
373 +# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.

378 +"Project-Id-Version: unity\n"
379 +"Report-Msgid-Bugs-To: \n"
380 +"POT-Creation-Date: 2013-05-22 20:32+0800\n"
381 +"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
382 +"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
383 +"Language-Team: LANGUAGE <email address hidden>\n"
384 +"Language: \n"

Please complete the header data.