Code review comment for lp:~paulliu/unity-scope-click/showratings
Revision history for this message
| Michael Nelson (michael.nelson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
TBH, I don't understand why we're using framework(s) for this interaction with the reviews api service at all.
As I understand it:
1) A click package definition can define the *required* frameworks that it needs.
2) A client can support multiple frameworks
3) The client already knows which apps it can install (from querying search.apps.u.c), and will only ever (?) want to retrieve reviews for apps it knows it can install, or submit reviews for apps it has already installed.
The review api service doesn't need to care what framework(s) the app requires (that's what search.apps.u.c is for), or which frameworks the client supports.
If it helps, I can send an email to the list to get more input, but IMO, we should just be sending distroseries=click as we were originally, or what am I missing?