Code review comment for lp:~paulliu/unity-mir/logout

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> So the thing is "indicator-session" will call the method "RequesetLogout". And
> the ApplicationManager will see if we have any important apps that inhibits
> the logout action ( while I don't think there's such app in Phone right now )
> and then send out the signal "LogoutRequested" with a boolean to indicate if
> there's such apps.
> And then Unity shell should receive that signal and display a dialog for the
> user to decide to logout or not.
> If the user decide to logout, then unity shell call the method "Logout" and we
> have to shutdown all the app. After that, we signal the shell to shut itself.

1- I asked you to document com.canonical.Unity.Session in its header, not in a merge request comment :D But thanks for the info. Now things are getting clearer.

2- So the D-Bus method Logout() from the com.canonical.Unity.Session service, which is provided by the unity8 process, is called by the unity8 process itself!?

3- What Unity shell is supposed to do with this "have_inhibitors" boolean? Display a different message in the logout dialog? I would refrain from adding such boolean until we actually have use for it. Development might change direction and this boolean could end up just as cruft.

« Back to merge proposal