Code review comment for lp:~paulliu/unity-mir/logout

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

The problem with your last suggestion Daniel would be that we'd (have to) block the UI thread during stopAllApplications, as we want to shut them down gracefully and only then shut Unity/Mir down. That's why I think the dual-signal approach will serve us better, even if we think the responsibilities should shift between unity8 and unity-mir.

I'm not entirely sure we want to move it up to the shell, though. If we think unity-mir is meant to facilitate building shells, the more we move up there, the more the shell needs to do. I can be convinced, though.

« Back to merge proposal