Merge lp:~paulliu/share-app/desktop_file_tweak into lp:share-app

Proposed by Ying-Chun Liu
Status: Merged
Approved by: Michał Sawicz
Approved revision: 44
Merged at revision: 43
Proposed branch: lp:~paulliu/share-app/desktop_file_tweak
Merge into: lp:share-app
Diff against target: 26 lines (+11/-0)
2 files modified
debian/changelog (+8/-0)
share-app.desktop (+3/-0)
To merge this branch: bzr merge lp:~paulliu/share-app/desktop_file_tweak
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Michał Sawicz Approve
Bill Filler (community) Approve
Review via email: mp+156560@code.launchpad.net

Commit message

Add NoDisplay=true into share-app.desktop.

Description of the change

Add NoDisplay=true into share-app.desktop.

To post a comment you must log in.
Martin Mrazik (mrazik) wrote :

I fixed the armhf issue.

Bill Filler (bfiller) wrote :

approve

review: Approve
Michał Sawicz (saviq) wrote :

This needs a "X-Ubuntu-Touch=true", too.

review: Needs Fixing
Michał Sawicz (saviq) wrote :

And X-Ubuntu-StageHint=SideStage

review: Needs Fixing
Michał Sawicz (saviq) :
review: Approve
Michał Sawicz (saviq) wrote :

I'm not sure what happens here, but it's unrelated to the changes in this MP :/

Michał Sawicz (saviq) wrote :

The two tests simply don't want to pass, we need help with this :/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-03-23 20:26:48 +0000
3+++ debian/changelog 2013-04-03 14:36:30 +0000
4@@ -1,3 +1,11 @@
5+share-app (0.11) quantal; urgency=low
6+
7+ * Add NoDisplay=true into share-app.desktop.
8+ * Add X-Ubuntu-Touch=true and X-Ubuntu-StageHint=SideStage into
9+ share-app.desktop.
10+
11+ -- Ying-Chun Liu (PaulLiu) <paul.liu@canonical.com> Wed, 03 Apr 2013 22:31:52 +0800
12+
13 share-app (0.10) quantal; urgency=low
14
15 * Update runtime dependencies:
16
17=== modified file 'share-app.desktop'
18--- share-app.desktop 2012-12-10 16:11:33 +0000
19+++ share-app.desktop 2013-04-03 14:36:30 +0000
20@@ -6,3 +6,6 @@
21 Exec=share-app %u
22 Terminal=false
23 Icon=share-app
24+NoDisplay=true
25+X-Ubuntu-Touch=true
26+X-Ubuntu-StageHint=SideStage

Subscribers

People subscribed via source and target branches