Merge lp:~paulgear/ubuntu-repository-cache/is-recent-updates into lp:~tribaal/ubuntu-repository-cache/trunk

Proposed by Paul Gear
Status: Merged
Merged at revision: 244
Proposed branch: lp:~paulgear/ubuntu-repository-cache/is-recent-updates
Merge into: lp:~tribaal/ubuntu-repository-cache/trunk
Diff against target: 48 lines (+5/-3)
4 files modified
config.yaml (+1/-1)
hooks/install (+1/-1)
lib/charmhelpers/core/host.py (+2/-0)
templates/cron/ubuntu-repository-cache_rsync.cron (+1/-1)
To merge this branch: bzr merge lp:~paulgear/ubuntu-repository-cache/is-recent-updates
Reviewer Review Type Date Requested Status
Chris Glass Approve
Review via email: mp+331997@code.launchpad.net

Description of the change

This includes recent IS changes in the hope that we'll be able to switch to the trunk branch shortly. The 'run-one' changes may not be necessary if you've taken other steps to ensure that cron runs do not overlap.

To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

This looks good!

Merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2017-03-20 20:03:32 +0000
3+++ config.yaml 2017-10-09 01:50:47 +0000
4@@ -9,7 +9,7 @@
5 default: ""
6 type: string
7 description: |
8- A space seperated list of ubuntu series metadata to mirror. An empty
9+ A space-separated list of ubuntu series metadata to mirror. An empty
10 or blank string will mirror everything.
11 sync-on-start:
12 default: true
13
14=== modified file 'hooks/install'
15--- hooks/install 2017-03-24 15:47:12 +0000
16+++ hooks/install 2017-10-09 01:50:47 +0000
17@@ -1,7 +1,7 @@
18 #! /bin/bash
19
20 # Install pre-install-hook dependencies (basically anything charmhelpers needs)
21-apt-get install -y python3-yaml python3-six python3-jinja2
22+apt-get install -y python3-yaml python3-six python3-jinja2 run-one
23
24 # Install the vendored python packages.
25 pushd .
26
27=== modified file 'lib/charmhelpers/core/host.py'
28--- lib/charmhelpers/core/host.py 2016-12-13 04:02:35 +0000
29+++ lib/charmhelpers/core/host.py 2017-10-09 01:50:47 +0000
30@@ -177,6 +177,8 @@
31
32 def init_is_systemd():
33 """Return True if the host system uses systemd, False otherwise."""
34+ if lsb_release()['DISTRIB_CODENAME'] == 'trusty':
35+ return False
36 return os.path.isdir(SYSTEMD_SYSTEM)
37
38
39
40=== modified file 'templates/cron/ubuntu-repository-cache_rsync.cron'
41--- templates/cron/ubuntu-repository-cache_rsync.cron 2017-08-22 08:22:27 +0000
42+++ templates/cron/ubuntu-repository-cache_rsync.cron 2017-10-09 01:50:47 +0000
43@@ -7,5 +7,5 @@
44 MIRROR_SERIES="{{ MirrorSeries }}"
45 # This cronjob will make the leader sync its view of the metadata with upstream
46 # It will then trigger a juju-run to let its peers synchronise.
47-{{ Minutes }} * * * * root python3 -m ubuntu_repository_cache.metadata_sync
48+{{ Minutes }} * * * * root run-one python3 -m ubuntu_repository_cache.metadata_sync
49

Subscribers

People subscribed via source and target branches

to all changes: