Code review comment for lp:~paulgear/python-oops-datedir-repo/variable-retention-period

Revision history for this message
Данило Шеган (danilo) wrote :

@Paul: sure, I am on the Landscape team, so as a former Launchpad developer (with review rights), I've decided to look at this to clean up the queue (or, tbh, I've been prodded by Adam Collard to do it :)).

I was wondering if IS knows where else is this code deployed so we can contain the risk of any change? Eg. I suspect at least Launchpad is using it, and I don't want it to fall over because there is no "logs" subdirectory somewhere.

As for merging, it is usually much easier and safer if you revert the change in question, so when "landing", I can simply merge your changes.

« Back to merge proposal