Merge ~paulgear/prometheus-pushgateway-charm/+git/prometheus-pushgateway-charm:master into ~stub/prometheus-pushgateway-charm:master

Proposed by Paul Gear
Status: Merged
Approved by: Haw Loeung
Approved revision: 10ab4a708a0ec064731b1184086fde71b51a8c0b
Merged at revision: cefa679b78de8dfec856b93fc4a0d8ced2c09448
Proposed branch: ~paulgear/prometheus-pushgateway-charm/+git/prometheus-pushgateway-charm:master
Merge into: ~stub/prometheus-pushgateway-charm:master
Diff against target: 51 lines (+20/-3)
3 files modified
config.yaml (+18/-1)
metadata.yaml (+1/-1)
templates/etc_default_prometheus-pushgateway.j2 (+1/-1)
Reviewer Review Type Date Requested Status
Haw Loeung Approve
Stuart Bishop Pending
Review via email: mp+327665@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/config.yaml b/config.yaml
2index 95d6a06..cc95499 100644
3--- a/config.yaml
4+++ b/config.yaml
5@@ -18,4 +18,21 @@ options:
6 default: ""
7 type: string
8 description: |
9- The minimum interval at which to write out the persistence file. Prometheus defalt is 5m0s
10+ The minimum interval at which to write out the persistence file.
11+ Prometheus' default is 5m0s.
12+ nagios_context:
13+ default: "juju"
14+ type: string
15+ description: |
16+ Used by the nrpe subordinate charms.
17+ A string that will be prepended to instance name to set the host name
18+ in nagios. So for instance the hostname would be something like:
19+ juju-myservice-0
20+ If you're running multiple environments with the same services in them
21+ this allows you to differentiate between them.
22+ nagios_servicegroups:
23+ default: ""
24+ type: string
25+ description: |
26+ A comma-separated list of nagios servicegroups.
27+ If left empty, the nagios_context will be used as the servicegroup
28diff --git a/metadata.yaml b/metadata.yaml
29index a273a24..6086bca 100644
30--- a/metadata.yaml
31+++ b/metadata.yaml
32@@ -1,6 +1,6 @@
33 name: prometheus-pushgateway
34 summary: Prometheus pushgateway
35-maintainer: JuanJo Ciarlante <JuanJo.Ciarlante@localhost>
36+maintainer: Prometheus Charmers <prometheus-charmers@lists.launchpad.net>
37 description: |
38 The Prometheus Pushgateway exists to allow ephemeral and batch jobs to
39 expose their metrics to Prometheus. Since these kinds of jobs may not
40diff --git a/templates/etc_default_prometheus-pushgateway.j2 b/templates/etc_default_prometheus-pushgateway.j2
41index 08dedad..9baf262 100644
42--- a/templates/etc_default_prometheus-pushgateway.j2
43+++ b/templates/etc_default_prometheus-pushgateway.j2
44@@ -8,7 +8,7 @@ ARGS="
45 "
46
47 ######################################################################################
48-# WARNINIG: Due to snap confinement the following options should not be set by hand: #
49+# WARNING: Due to snap confinement, the following options should not be set by hand: #
50 ######################################################################################
51 # -persistence.file string
52

Subscribers

People subscribed via source and target branches

to all changes: