Code review comment for ~paulgear/ntp-charm/+git/ntp-charm:autopeers

Revision history for this message
Paul Gear (paulgear) wrote :

On 07/11/17 19:10, Stuart Bishop wrote:
> Review: Approve
> Looks good.
> You probably want 'fatal=True' in install_packages(), which I missed last time. I doubt the rest of this charm will work if the packages are missing, so its better to fail early.

The rest of the charm should work fine if those packages are missing,
and the scoring & auto-peering should fail gracefully if they are.

I've pushed a fix to handle the case where python3-psutil is missing.

« Back to merge proposal