NTP Charm

Code review comment for ~paulgear/ntp-charm/+git/ntp-charm:autopeers

  1. Git
  2. lp:~paulgear/ntp-charm/+git/ntp-charm
  3. autopeers
  4. Merge into master
Revision history for this message
Stuart Bishop (stub) wrote :

Looks good.

You probably want 'fatal=True' in install_packages(), which I missed last time. I doubt the rest of this charm will work if the packages are missing, so its better to fail early.

review: Approve

« Back to merge proposal