Code review comment for ~paulgear/ntp-charm/+git/ntp-charm:autopeers

Revision history for this message
Tom Haddon (mthaddon) wrote :

I get a "make lint" error from this:

hooks/ C901 'write_config' is too complex (10)

You may want to consider ignoring that in the default lint target and adding a "complex-lint" target that doesn't ignore it so you can work it down to zero over time.

How does some use You mention in the comments for that file that it can be for diagnostic purposes. That sounds like something that would be nice to expose via juju actions. I don't think that should necessarily block the landing of this, but if you're planning to advertise that functionality at all, I think it should be done via juju actions first.

« Back to merge proposal