Merge lp:~paulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries into lp:charms/nrpe-external-master

Proposed by Paul Gear
Status: Merged
Merged at revision: 39
Proposed branch: lp:~paulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries
Merge into: lp:charms/nrpe-external-master
Diff against target: 24 lines (+2/-2)
2 files modified
hooks/install (+1/-1)
tests/99-autogen (+1/-1)
To merge this branch: bzr merge lp:~paulgear/charms/precise/nrpe-external-master/fix-duplicate-rsync-entries
Reviewer Review Type Date Requested Status
Adam Israel (community) Approve
Review Queue (community) Needs Fixing
Brad Marshall (community) Approve
charmers Pending
Review via email: mp+250248@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brad Marshall (brad-marshall) wrote :

Looks good to me.

review: Approve
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-11054-results

review: Needs Fixing (automated testing)
40. By Paul Gear

Increase timeout to 30 minutes to allow Azure test to complete

Revision history for this message
Adam Israel (aisrael) wrote :

Hi Paul,

This looks good to me, too. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/install'
2--- hooks/install 2014-11-18 01:23:42 +0000
3+++ hooks/install 2015-02-27 05:17:50 +0000
4@@ -22,6 +22,6 @@
5 export NAGIOS_MASTER=$(config-get nagios_master)
6 cheetah fill --env --oext compiled templates/rsyncd.conf.tmpl
7 mkdir -p /etc/rsync-juju.d
8-cp templates/rsyncd.conf.compiled /etc/rsync-juju.d/010-nrpe-external-master
9+cp templates/rsyncd.conf.compiled /etc/rsync-juju.d/010-nrpe-external-master.conf
10
11 service rsync restart
12
13=== modified file 'tests/99-autogen'
14--- tests/99-autogen 2014-11-06 21:25:39 +0000
15+++ tests/99-autogen 2015-02-27 05:17:50 +0000
16@@ -18,7 +18,7 @@
17 cls.deployment.expose('nagios')
18
19 try:
20- cls.deployment.setup(timeout=900)
21+ cls.deployment.setup(timeout=1800)
22 cls.deployment.sentry.wait()
23 except amulet.helpers.TimeoutError:
24 amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")

Subscribers

People subscribed via source and target branches

to all changes: