Code review comment for lp:~paulgear/bzr/proxy-environment-default

Richard Wilbur (richard-wilbur) wrote :

Like I replied to the old merge proposal with the new patch:

Good work, Paul. Your new version doesn't lengthen library load time. Thanks for the fix.

Regarding security issues: this solution still allows calling with a proxy specified explicitly in the argument list, only the default behaviour is changed and that is now to use the https proxy configured for the system. I still don't see a problem.

+1

Now, with that in the new merge proposal, I can actually approve the correct ("unsuperseded") proposal.

review: Approve

« Back to merge proposal