Code review comment for lp:~paulgear/bzr/proxy-environment-default

Martin Pool (mbp) wrote :

Thanks for proposing a patch for this.

Generally, calling functions or capturing values from a function default
value (therefore at module load time) is an antipattern in Python - it's
better to make it None and then set it inside the function. Unless there's
something I'm missing, but then there should probably be a comment.

« Back to merge proposal