Merge lp:~paulbrianstewart/ubuntu/oneiric/visualvm/813165-formattingTypo into lp:ubuntu/oneiric/visualvm

[Paul Stewart]

  Changed the bullet point formatting. This was formatted incorrectly and causing the first line to delete the first 2 characters of the word 'VisualVM....'
  I added 's' to the end of the words 'Application Developer', System Administrator' and 'Java Application User'.

I have updated the control file for the Ubuntu Software Center VisualVM 'More Info' page.

Changes:
  Changed the bullet point formatting. This was formatted incorrectly and causing the first line to delete the first 2 characters of the word 'VisualVM....'
  I added 's' to the end of the words 'Application Developer', System Administrator' and 'Java Application User'.

[Micah Gersten (micahg)]

@mpt, can you look at this? The adding of the s makes sense, but I'm just wondering if there's any other tweaking needed.

@Paul Stewart
This looks good overall, I'm just asking a colleague with a knack for word interaction to have a look.

[Paul Stewart (paulbrianstewart)]

> @mpt, can you look at this? The adding of the s makes sense, but I'm just
> wondering if there's any other tweaking needed.
>
> @Paul Stewart
> This looks good overall, I'm just asking a colleague with a knack for word
> interaction to have a look.

Thanks Micah,

Please change anything I did as you see fit. I haven't encountered that type of formatting problem before, so I changed it the way I thought it would work. I hope it was helpful.

Thanks
Paul Stewart

[Matthew Paul Thomas (mpt)]

review: Approve (design)

[Luke Yelavich (themuso)]

I'd upload this, however I cannot get it to build, due to broken dependencies. The work itself is fine, and the work you have done does not affect the package build process itself, but dependencies further up the chain are currently broken and fail to build, and I have no idea how to properly fix them.

Thanks for your work nonetheless.

If another pilot/sponsor who knos more about java could try and aaddress this properly, that would be appreciated.

review: Approve

[Paul Stewart (paulbrianstewart)]

> I'd upload this, however I cannot get it to build, due to broken dependencies.
> The work itself is fine, and the work you have done does not affect the
> package build process itself, but dependencies further up the chain are
> currently broken and fail to build, and I have no idea how to properly fix
> them.
>
> Thanks for your work nonetheless.
>
> If another pilot/sponsor who knos more about java could try and aaddress this
> properly, that would be appreciated.

Ok, thanks Luke,
Hope it gets worked out ok. Trust I helped a little.

Thanks for your hard work.
Paul Stewart

[Stefano Rivera (stefanor)]

You need the " ." to separate the paragraphs.

[lp:~paulbrianstewart/ubuntu/oneiric/visualvm/813165-formattingTypo]

16. By Paul Stewart on 2011-08-18

Added the "." to separate the paragraphs.

[Paul Stewart (paulbrianstewart)]

> You need the " ." to separate the paragraphs.

Hi Stefano,

I have added the "." to separate the paragraphs as you explained.

Trust this helps. Let me know if you need anything else.

Thanks
Paul

review: Needs Resubmitting

[Paul Stewart (paulbrianstewart)]

> @mpt, can you look at this? The adding of the s makes sense, but I'm just
> wondering if there's any other tweaking needed.
>
> @Paul Stewart
> This looks good overall, I'm just asking a colleague with a knack for word
> interaction to have a look.

Hi Micah,

I had to resubmit it with the '.' to format the paragraphs.
If you have time could you please review it and approve it again?

Thanks
Paul

review: Needs Resubmitting

[Jani Monoses (jani)]

This could use a changelog entry too, care to craft one? I wonder if we should just upload it anyway to not loose the change and deal with the build breakage later on. Seems like quite some work, try
apt-get build-dep visualvm
Fixing that would be a great new contribution :)

[Paul Stewart (paulbrianstewart)]

> This could use a changelog entry too, care to craft one? I wonder if we should
> just upload it anyway to not loose the change and deal with the build breakage
> later on. Seems like quite some work, try
> apt-get build-dep visualvm
> Fixing that would be a great new contribution :)

Hi Janis,

I'll try to do that.
Thanks
Paul Stewart

[Paul Stewart (paulbrianstewart)]

> This could use a changelog entry too, care to craft one? I wonder if we should
> just upload it anyway to not loose the change and deal with the build breakage
> later on. Seems like quite some work, try
> apt-get build-dep visualvm
> Fixing that would be a great new contribution :)

Hi Janis,

I jumped too soon...I just realized that I actually don't know how to do that. I'll research and see if I can figure it out (it's not too hard is it?). But you may want to load the changes. Your choice of course.

Thanks
Paul

[Stefano Rivera (stefanor)]

This was merged in visualvm 1.3.2-0ubuntu1

[Paul Stewart (paulbrianstewart)]

> This was merged in visualvm 1.3.2-0ubuntu1
Cool..thanks

=== modified file 'debian/control'
--- debian/control	2010-08-26 22:24:21 +0000
+++ debian/control	2011-08-18 21:00:30 +0000
@@ -14,11 +14,11 @@
  and lightweight profiling capabilities. Designed for both production
  and development time use, it further enhances the capability of
  monitoring and performance analysis for the Java SE platform.
- .
+. 
  VisualVM is designed for
-  - Application Developer: Monitor, profile, take thread dumps,
+  - Application Developers: Monitor, profile, take thread dumps,
     browse heap dumps.
-  - System Administrator: Monitor and control Java applications
+  - System Administrators: Monitor and control Java applications
     across the entire network.
-  - Java Application User: Create bug reports containing all the
+  - Java Application Users: Create bug reports containing all the
     necessary information.