Merge lp:~paulbrianstewart/ubuntu/oneiric/sauerbraten/858631-Spelling-Error-Fix into lp:ubuntu/oneiric/sauerbraten

Proposed by Paul Stewart
Status: Needs review
Proposed branch: lp:~paulbrianstewart/ubuntu/oneiric/sauerbraten/858631-Spelling-Error-Fix
Merge into: lp:ubuntu/oneiric/sauerbraten
Diff against target: 33 lines (+3/-6)
1 file modified
debian/control (+3/-6)
To merge this branch: bzr merge lp:~paulbrianstewart/ubuntu/oneiric/sauerbraten/858631-Spelling-Error-Fix
Reviewer Review Type Date Requested Status
Martin Pitt Needs Fixing
Review via email: mp+76882@code.launchpad.net

Commit message

* Added commas after 'networked', 'fast-paced', and '3D'.
* Deleted the 'a' before 'some'
* Deleted the word 'rather'.

Description of the change

* Added commas after 'networked', 'fast-paced', and '3D'.
* Deleted the 'a' before 'some'
* Deleted the word 'rather'.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Paul! It is not worth introducing a delta to Debian for this minor issue, and Oneiric is currently in string freeze anyway (package descriptions are translated, too).

It seems you accidentally removed the line breaks, lines in the control files must not exceed 79 characters. Also, I'm not a native speaker, but adding all the commas there looks strange to me. Perhaps a native speaker can review that.

I suggest that you forward this as a Debian bug, so that it can be fixed there and trickle back down into Ubuntu in the next cycle? The Debian Games team might also have some native English speakers.

Thanks!

review: Needs Fixing
Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

> Thanks Paul! It is not worth introducing a delta to Debian for this minor
> issue, and Oneiric is currently in string freeze anyway (package descriptions
> are translated, too).
>
> It seems you accidentally removed the line breaks, lines in the control files
> must not exceed 79 characters. Also, I'm not a native speaker, but adding all
> the commas there looks strange to me. Perhaps a native speaker can review
> that.
>
> I suggest that you forward this as a Debian bug, so that it can be fixed there
> and trickle back down into Ubuntu in the next cycle? The Debian Games team
> might also have some native English speakers.
>
> Thanks!

Ok, thanks Martin,

I'll have another look and forward it as well. I'll get my wife to check the grammar and so on as she's an English Literature teacher. I should have asked her before I sent it :)
Have a great day.
Thanks
Paul

Unmerged revisions

17. By Paul Stewart

* Added commas after 'networked', 'fast-paced', and '3D'.
* Deleted the 'a' before 'some'
* Deleted the word 'rather'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2011-06-03 19:03:03 +0000
3+++ debian/control 2011-09-25 04:07:11 +0000
4@@ -19,8 +19,7 @@
5 Depends: ${misc:Depends}, ${shlibs:Depends}, sauerbraten-data (>= ${sauerbraten-data-ver})
6 Recommends: sauerbraten-wake6
7 Description: 3D first-person game engine
8- Sauerbraten is a networked fast-paced 3D first-person shooter game. It supports
9- rather modern graphic effects and a some nice graphic details.
10+ Sauerbraten is a networked, fast-paced, 3D, first-person shooter game. It supports modern graphic effects and some nice graphic details.
11 .
12 The game client also works as the map editor. It is even possible to create
13 and/or edit a map together with other people over a network connection.
14@@ -35,8 +34,7 @@
15 Architecture: any
16 Depends: ${misc:Depends}, sauerbraten (= ${binary:Version})
17 Description: Debug symbols for the Sauerbraten game engine
18- Sauerbraten is a networked fast-paced 3D first-person shooter game. It supports
19- rather modern graphic effects and a some nice graphic details.
20+ Sauerbraten is a networked, fast-paced, 3D, first-person shooter game. It supports modern graphic effects and some nice graphic details.
21 .
22 The game client also works as the map editor. It is even possible to create
23 and/or edit a map together with other people over a network connection.
24@@ -50,8 +48,7 @@
25 Depends: ${misc:Depends}, ${shlibs:Depends}
26 Suggests: sauerbraten
27 Description: Standalone server for the Sauerbraten game
28- Sauerbraten is a networked fast-paced 3D first-person shooter game. It supports
29- rather modern graphic effects and a some nice graphic details.
30+ Sauerbraten is a networked, fast-paced, 3D, first-person shooter game. It supports modern graphic effects and some nice graphic details.
31 .
32 The game client also works as the map editor. It is even possible to create
33 and/or edit a map together with other people over a network connection.

Subscribers

People subscribed via source and target branches

to all changes: