Merge lp:~paulbrianstewart/ubuntu/oneiric/gpredict/859367-Spelling-Grammar-Fix into lp:ubuntu/oneiric/gpredict

Proposed by Paul Stewart
Status: Rejected
Rejected by: Stéphane Graber
Proposed branch: lp:~paulbrianstewart/ubuntu/oneiric/gpredict/859367-Spelling-Grammar-Fix
Merge into: lp:ubuntu/oneiric/gpredict
Diff against target: 27 lines (+5/-5)
1 file modified
debian/control (+5/-5)
To merge this branch: bzr merge lp:~paulbrianstewart/ubuntu/oneiric/gpredict/859367-Spelling-Grammar-Fix
Reviewer Review Type Date Requested Status
Clint Byrum (community) Disapprove
Michael Vogt (community) Needs Information
Ubuntu branches Pending
Review via email: mp+76934@code.launchpad.net

Commit message

* Changed the word order of the words "...only limited..." to "...limited only..." in the first bullet list sentence.
* Changed "and" to "or" in the second bullet point list
* Added the missing word "time" after the word "same" in the third bullet point list.
* Deleted the word "either" in the fourth bullet point list as it's not required and helps the sentence to sound better (my opinion).
* Corrected incorrect spelling of "approximate" in the fourth bullet list.
* Added the missing word "open." at the end of the fifth bullet point list.

Description of the change

* Changed the word order of the words "...only limited..." to "...limited only..." in the first bullet list sentence.
* Changed "and" to "or" in the second bullet point list
* Added the missing word "time" after the word "same" in the third bullet point list.
* Deleted the word "either" in the fourth bullet point list as it's not required and helps the sentence to sound better (my opinion).
* Corrected incorrect spelling of "approximate" in the fourth bullet list.
* Added the missing word "open." at the end of the fifth bullet point list.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your patch!

The new version sounds better for the most part, however, I'm not sure
that "* Added the missing word "open." at the end of the fifth bullet point list."
is corecct:
"""
  * Predict upcoming passes for satellites, including passes where a
    satellite may be visible and communication windows open.
"""

Shouldn't this be something like
"""
  * Predict upcoming passes for satellites, including passes where a
    satellite may be visible and the communication windows open.
"""
?

Note that I'm not a native speaker nor a satellite guy, so I may be wrong here.

review: Needs Information
Revision history for this message
Colin Watson (cjwatson) wrote :

On Mon, Sep 26, 2011 at 12:41:17PM -0000, Michael Vogt wrote:
> The new version sounds better for the most part, however, I'm not sure
> that "* Added the missing word "open." at the end of the fifth bullet point list."
> is corecct:
> """
> * Predict upcoming passes for satellites, including passes where a
> satellite may be visible and communication windows open.
> """
>
> Shouldn't this be something like
> """
> * Predict upcoming passes for satellites, including passes where a
> satellite may be visible and the communication windows open.
> """
> ?

I would prefer the first version here.

Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

Hi Colin, Michael,

Thanks for reviewing this. In regards to the fifth bullet point please use whichever you feel is better. I just went with what 'flowed' off of my mind, which is by no means always correct :) . Personally I prefer the one I wrote, but adding the 'the' sounds ok to me as well, so please choose whichever you prefer.

I'm not an English major so I won't pretend I know the correct grammar always.

Thanks
Paul

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

This was fixed in Debian, and will be incorporated in the next merge or sync.

review: Disapprove
Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

Thanks Clint

Unmerged revisions

20. By Paul Stewart

* Changed the word order of the words "...only limited..." to "...limited only..." in the first bullet list sentence.
* Changed "and" to "or" in the second bullet point list
* Added the missing word "time" after the word "same" in the third bullet point list.
* Deleted the word "either" in the fourth bullet point list as it's not required and helps the sentence to sound better (my opinion).
* Corrected incorrect spelling of "approximate" in the fourth bullet list.
* Added the missing word "open." at the end of the fifth bullet point list.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2011-07-19 17:18:01 +0000
3+++ debian/control 2011-09-26 04:45:27 +0000
4@@ -16,18 +16,18 @@
5 .
6 Gpredict includes the following features:
7 .
8- * Tracking an infinite number of satellites only limited by the
9+ * Tracking an infinite number of satellites limited only by the
10 physical memory and processing power of the computer.
11- * Display the tracking data in lists, maps, polar plots and any
12+ * Display the tracking data in lists, maps, polar plots or any
13 combination of these.
14- * You can have many modules open at the same either in a
15+ * You can have many modules open at the same time, either in a
16 notebook or in their own windows. The module can also run in
17 full-screen mode.
18 * You can use many ground stations. Ground station coordinates
19- can either be entered manually or you can get some appriximate values
20+ can be entered manually or you can get some approximate values
21 from a list with more than 2000 predefined locations worldwide.
22 * Predict upcoming passes for satellites, including passes where a
23- satellite may be visible and communication windows
24+ satellite may be visible and communication windows open.
25 * Very detailed information about both the real time data and the
26 predicted passes.
27 * Gpredict can run in real-time, simulated real-time (fast forward and

Subscribers

People subscribed via source and target branches

to all changes: