Merge lp:~paulbrianstewart/ubuntu/oneiric/gpredict/859367-Spelling-Grammar-Fix into lp:ubuntu/oneiric/gpredict
Status: | Rejected |
---|---|
Rejected by: | Stéphane Graber |
Proposed branch: | lp:~paulbrianstewart/ubuntu/oneiric/gpredict/859367-Spelling-Grammar-Fix |
Merge into: | lp:ubuntu/oneiric/gpredict |
Diff against target: |
27 lines (+5/-5) 1 file modified
debian/control (+5/-5) |
To merge this branch: | bzr merge lp:~paulbrianstewart/ubuntu/oneiric/gpredict/859367-Spelling-Grammar-Fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Clint Byrum (community) | Disapprove | ||
Michael Vogt (community) | Needs Information | ||
Ubuntu branches | Pending | ||
Review via email: mp+76934@code.launchpad.net |
Commit message
* Changed the word order of the words "...only limited..." to "...limited only..." in the first bullet list sentence.
* Changed "and" to "or" in the second bullet point list
* Added the missing word "time" after the word "same" in the third bullet point list.
* Deleted the word "either" in the fourth bullet point list as it's not required and helps the sentence to sound better (my opinion).
* Corrected incorrect spelling of "approximate" in the fourth bullet list.
* Added the missing word "open." at the end of the fifth bullet point list.
Description of the change
* Changed the word order of the words "...only limited..." to "...limited only..." in the first bullet list sentence.
* Changed "and" to "or" in the second bullet point list
* Added the missing word "time" after the word "same" in the third bullet point list.
* Deleted the word "either" in the fourth bullet point list as it's not required and helps the sentence to sound better (my opinion).
* Corrected incorrect spelling of "approximate" in the fourth bullet list.
* Added the missing word "open." at the end of the fifth bullet point list.
Unmerged revisions
- 20. By Paul Stewart
-
* Changed the word order of the words "...only limited..." to "...limited only..." in the first bullet list sentence.
* Changed "and" to "or" in the second bullet point list
* Added the missing word "time" after the word "same" in the third bullet point list.
* Deleted the word "either" in the fourth bullet point list as it's not required and helps the sentence to sound better (my opinion).
* Corrected incorrect spelling of "approximate" in the fourth bullet list.
* Added the missing word "open." at the end of the fifth bullet point list.
Thanks for your patch!
The new version sounds better for the most part, however, I'm not sure
that "* Added the missing word "open." at the end of the fifth bullet point list."
is corecct:
"""
* Predict upcoming passes for satellites, including passes where a
satellite may be visible and communication windows open.
"""
Shouldn't this be something like
"""
* Predict upcoming passes for satellites, including passes where a
satellite may be visible and the communication windows open.
"""
?
Note that I'm not a native speaker nor a satellite guy, so I may be wrong here.