Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas on 2013-05-18
Status: Merged
Approved by: Paul J. Lucas on 2013-05-20
Approved revision: 11221
Merged at revision: 11462
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 12 lines (+1/-1)
1 file modified
src/zorbautils/locale.cpp (+1/-1)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Federico Cavalieri 2013-05-18 Approve on 2013-05-20
Paul J. Lucas Approve on 2013-05-18
Review via email: mp+164563@code.launchpad.net

Commit message

Fix the use of setlocale(3) in locale.cpp reported by Federico Cavalieri.

Description of the change

Fix the use of setlocale(3) in locale.cpp reported by Federico Cavalieri.

To post a comment you must log in.
Paul J. Lucas (paul-lucas) :
review: Approve
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-18T01-09-42.757Z is finished. The final status was:

All tests succeeded!

Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve.

review: Approve
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-20T15-41-42.269Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/zorbautils/locale.cpp'
2--- src/zorbautils/locale.cpp 2013-04-02 21:40:03 +0000
3+++ src/zorbautils/locale.cpp 2013-05-18 00:55:30 +0000
4@@ -233,7 +233,7 @@
5 //
6 // Try the environment locale first.
7 //
8- char const *loc = filter_useless_locale( ::setlocale( LC_ALL, "" ) );
9+ char const *loc = filter_useless_locale( ::setlocale( LC_ALL, nullptr ) );
10 if ( !loc ) {
11 //
12 // Try the "LANG" environment variable second.

Subscribers

People subscribed via source and target branches