Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Chris Hillery
Approved revision: 11079
Merged at revision: 11248
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 53 lines (+5/-5)
3 files modified
src/diagnostics/diagnostic_en.xml (+2/-2)
src/diagnostics/pregenerated/dict_en.cpp (+2/-2)
src/util/utf8_streambuf.h (+1/-1)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+149845@code.launchpad.net

Commit message

Fixed escaping of $ and a comment.

Description of the change

Fixed escaping of $ and a comment.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message):
  Validation queue job pjl-misc-2013-02-21T18-03-56.396Z is finished. The
  final status was:

  1 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-02-21T20-53-51.77Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/diagnostics/diagnostic_en.xml'
2--- src/diagnostics/diagnostic_en.xml 2013-02-09 00:26:52 +0000
3+++ src/diagnostics/diagnostic_en.xml 2013-02-21 14:34:23 +0000
4@@ -3659,7 +3659,7 @@
5 </entry>
6
7 <entry key="NonClosedBackRef_3" if="!defined(ZORBA_NO_ICU)">
8- <value>'$$3': non-closed backreference</value>
9+ <value>'\$$3': non-closed backreference</value>
10 </entry>
11
12 <entry key="NonFileThesaurusURI">
13@@ -3671,7 +3671,7 @@
14 </entry>
15
16 <entry key="NonexistentBackRef_3" if="!defined(ZORBA_NO_ICU)">
17- <value>'$$3': non-existent backreference</value>
18+ <value>'\$$3': non-existent backreference</value>
19 </entry>
20
21 <entry key="NotAllowedForTypeName">
22
23=== modified file 'src/diagnostics/pregenerated/dict_en.cpp'
24--- src/diagnostics/pregenerated/dict_en.cpp 2013-02-09 00:26:52 +0000
25+++ src/diagnostics/pregenerated/dict_en.cpp 2013-02-21 14:34:23 +0000
26@@ -713,12 +713,12 @@
27 { "~NodeIDNeedsBytes_2", "nodeid requires more than $2 bytes" },
28 { "~NodeIDTooBig", "nodeid component too big for encoding" },
29 #if !defined(ZORBA_NO_ICU)
30- { "~NonClosedBackRef_3", "'$$3': non-closed backreference" },
31+ { "~NonClosedBackRef_3", "'\\$$3': non-closed backreference" },
32 #endif
33 { "~NonFileThesaurusURI", "non-file thesaurus URI" },
34 { "~NonLocalhostAuthority", "non-localhost authority" },
35 #if !defined(ZORBA_NO_ICU)
36- { "~NonexistentBackRef_3", "'$$3': non-existent backreference" },
37+ { "~NonexistentBackRef_3", "'\\$$3': non-existent backreference" },
38 #endif
39 { "~NotAllowedForTypeName", "not allowed for typeName (use xsd:untyped instead)" },
40 { "~NotAmongInScopeSchemaTypes", "not among in-scope schema types" },
41
42=== modified file 'src/util/utf8_streambuf.h'
43--- src/util/utf8_streambuf.h 2013-02-12 03:55:18 +0000
44+++ src/util/utf8_streambuf.h 2013-02-21 14:34:23 +0000
45@@ -194,7 +194,7 @@
46 * and automatically detaches it when the %auto_attach object is destroyed.
47 * \code
48 * void f( ostream &os ) {
49- * utf8::auto_attach<ostream> const raii( os, "ISO-8859-1" );
50+ * utf8::auto_attach<ostream> const raii( os );
51 * // ...
52 * }
53 * \endcode

Subscribers

People subscribed via source and target branches