Code review comment for lp:~paul-lucas/zorba/pjl-misc

Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

Shouldn't the following be rewritten for performance:

return s1_n == s2_n && (s1 == s2 || std::memcmp( s1, s2, s1_n ) == 0);

=>

return s1_n == s2_n && (std::memcmp( s1, s2, s1_n ) == 0 ||s1 == s2);

review: Needs Information

« Back to merge proposal