Merge lp:~paul-lucas/zorba/bug-980463 into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Matthias Brantner
Approved revision: 10758
Merged at revision: 10768
Proposed branch: lp:~paul-lucas/zorba/bug-980463
Merge into: lp:zorba
Diff against target: 33 lines (+3/-7)
1 file modified
src/zorbaserialization/class_serializer.h (+3/-7)
To merge this branch: bzr merge lp:~paul-lucas/zorba/bug-980463
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+102014@code.launchpad.net

Commit message

Now comparing name() to name().

Description of the change

Now comparing name() to name().

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-980463-2012-04-16T16-49-14.305Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/zorbaserialization/class_serializer.h'
2--- src/zorbaserialization/class_serializer.h 2012-04-14 01:36:33 +0000
3+++ src/zorbaserialization/class_serializer.h 2012-04-14 15:29:20 +0000
4@@ -142,18 +142,16 @@
5 class_name::serialize(ar); \
6 }
7
8-
9 #ifndef NDEBUG
10 #define CHECK_CLASS_NAME(class_name)\
11-if (ar.is_serializing_out() && !ar.is_serialize_base_class()) \
12-{ \
13- assert(strstr(typeid(*this).name(), #class_name)); \
14+if (ar.is_serializing_out() && !ar.is_serialize_base_class()) \
15+{ \
16+ assert(::strcmp(typeid(*this).name(), typeid(class_name).name()) == 0); \
17 }
18 #else
19 #define CHECK_CLASS_NAME(class_name)
20 #endif
21
22-
23 /*******************************************************************************
24 Every serializable class C has a nested member class D that is a subclass of
25 ClassDeserializer. Furthermore, every serializable class has a static data
26@@ -374,8 +372,6 @@
27 { \
28 }
29
30-
31-
32 } // namespace serialization
33 } // namespace zorba
34

Subscribers

People subscribed via source and target branches