Merge lp:~paul-lucas/zorba/bug-944826 into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 10694
Merged at revision: 10705
Proposed branch: lp:~paul-lucas/zorba/bug-944826
Merge into: lp:zorba
Diff against target: 11 lines (+1/-0)
1 file modified
src/util/string/ptr_rep.tcc (+1/-0)
To merge this branch: bzr merge lp:~paul-lucas/zorba/bug-944826
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Matthias Brantner Approve
Review via email: mp+95589@code.launchpad.net

This proposal supersedes a proposal from 2012-03-02.

Commit message

Set dispose_data_using_delete_ = false in reserve().

Description of the change

Set dispose_data_using_delete_ = false in reserve().

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

I forgot to to the commit before submitting the first merge proposal.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-944826-2012-03-02T16-48-06.224Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 3 Pending.

Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~paul-lucas/zorba/bug-944826 into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message):
  Validation queue job bug-944826-2012-03-04T07-57-03.742Z is finished. The
  final status was:

  1 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-944826-2012-03-06T18-52-59.572Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/util/string/ptr_rep.tcc'
2--- src/util/string/ptr_rep.tcc 2011-07-16 23:23:56 +0000
3+++ src/util/string/ptr_rep.tcc 2012-03-02 15:35:23 +0000
4@@ -169,6 +169,7 @@
5 pointer const p = clone_data_only( alloc, cap );
6 dispose_data_only( alloc );
7 p_ = p;
8+ dispose_data_using_delete_ = false;
9 this->cap_ = cap;
10 }
11 return this;

Subscribers

People subscribed via source and target branches