Code review comment for lp:~paul-lucas/zorba/bug-1147518
Revision history for this message
| Paul J. Lucas (paul-lucas) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> We have to agree on which error raising macro is used where. It doesn't make
> sense to go back and forth between "throw XQUERY_EXCEPTION" and "RAISE_ERROR".
RAISE_ERROR was something that Markos introduced. It's completely unnecessary. It gratuitously changes the order or the arguments.
It doesn't work for ZORBA_EXCEPTION (which often means that code is incorrectly throwing an XQueryException rather than a ZorbaException where a ZorbaException is the correct exception to throw).
There are 4 flavors of the macro that are difficult to remember. Those 4 flavors don't even cover all cases. These macros are similar to the original, ugly error macros.
Since Markos is intransigent, the only thing we can do is to not approve merge proposals if anybody other than Markos uses the macros.