Merge lp:~paul-codesourcery/ubuntu/maverick/mysql-dfsg-5.1/gcc_abi_check_hack into lp:ubuntu/maverick/mysql-dfsg-5.1

Proposed by Paul Brook
Status: Work in progress
Proposed branch: lp:~paul-codesourcery/ubuntu/maverick/mysql-dfsg-5.1/gcc_abi_check_hack
Merge into: lp:ubuntu/maverick/mysql-dfsg-5.1
Diff against target: 57 lines (+53/-0)
1 file modified
debian/patches/03_abi_check_gcc_hack.dpatch (+53/-0)
To merge this branch: bzr merge lp:~paul-codesourcery/ubuntu/maverick/mysql-dfsg-5.1/gcc_abi_check_hack
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+29680@code.launchpad.net

Description of the change

Fixes build failure on recent GCC (4.5 and linaro-gcc 4.4).
Modified version of upstream workaround (http://lists.mysql.com/commits/112967).

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

As the bug appears to be closed, marking this WIP.

Unmerged revisions

32. By Paul Brook

Backport of workaround for upstream Bug #52514, tweaked to include GCC4.4
(for linaro builds)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/03_abi_check_gcc_hack.dpatch'
2--- debian/patches/03_abi_check_gcc_hack.dpatch 1970-01-01 00:00:00 +0000
3+++ debian/patches/03_abi_check_gcc_hack.dpatch 2010-07-12 09:17:59 +0000
4@@ -0,0 +1,53 @@
5+#! /bin/sh /usr/share/dpatch/dpatch-run
6+## 03_abi_check_gcc_hack.dpatch by Paul Brook <paul@codesourcery.com>
7+##
8+## All lines beginning with `## DP:' are a description of the patch.
9+## DP: Disable broken abi_check on recent GCC (>= 4.4)
10+## DP: Upstream Bug #51524
11+
12+@DPATCH@
13+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' mysql~/configure mysql/configure
14+--- mysql~/configure 2010-07-12 08:31:09.000000000 +0000
15++++ mysql/configure 2010-07-12 08:55:56.810534091 +0000
16+@@ -18648,7 +18648,18 @@
17+ then
18+ ABI_CHECK=""
19+ else
20+- ABI_CHECK="abi_check"
21++ # Workaround GCC >= 4.5 - See Bug#52514
22++ # Alsorequired for some variants of GCC 4.4
23++ case `$CC -dumpversion` in
24++ 4.[4-9]* | 5.*)
25++ { $as_echo "$as_me:$LINENO: WARNING: ABI check disabled (GCC >= 4.4)" >&5
26++$as_echo "$as_me: WARNING: ABI check disabled (GCC >= 4.4)" >&2;}
27++ ABI_CHECK=""
28++ ;;
29++ *)
30++ ABI_CHECK="abi_check"
31++ ;;
32++ esac
33+ fi
34+
35+
36+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' mysql~/configure.in mysql/configure.in
37+--- mysql~/configure.in 2010-07-12 08:31:09.000000000 +0000
38++++ mysql/configure.in 2010-07-12 08:55:56.810534091 +0000
39+@@ -464,7 +464,17 @@
40+ then
41+ ABI_CHECK=""
42+ else
43+- ABI_CHECK="abi_check"
44++ # Workaround GCC >= 4.5 - See Bug#52514
45++ # Alsorequired for some variants of GCC 4.4
46++ case `$CC -dumpversion` in
47++ 4.[[4-9]]* | 5.*)
48++ AC_MSG_WARN([ABI check disabled (GCC >= 4.4)])
49++ ABI_CHECK=""
50++ ;;
51++ *)
52++ ABI_CHECK="abi_check"
53++ ;;
54++ esac
55+ fi
56+
57+ AC_SUBST(ABI_CHECK)

Subscribers

People subscribed via source and target branches

to all changes: