Do not run flake8 during 'make test', remove 'trusty-flake8' tox env.
Previously 'make test' would run flake8. That meant that during
a package build a flake8 failure would cause package failure.
We do not really care about flake8 errors (primarily style) at that
point. Rather, upstream has picked versions of
flake8, pycodestyle, and pyflakes that it will ensure code is good with.
Along that same line, there is no need for the tox 'trusty-flake8'
environment which was present to catch those errors before a package
build on trusty.
The changes here mean that 'make test' won't run flake8. Note,
make can still be explicitly invoked with 'flake8' target.
This means that the bin/sstream-mirror-glance Python script (rather than
the tools/sstream-mirror-glance shell script that redirects to the
Python script) comes first in PATH.
tools/install-deps: install enough deps for ./tools/build-deb to work.
Basic goal here is to have this work:
./tools/install-deps build && ./tools/build-deb
Changes:
a.) fix a bug parsing debian/control (it would miss 'debhelper')
b.) install fakeroot explicitly, otherwise 'debuild' wont work.
c.) install with --no-install-recommends. This just gets less stuff
and means we're more explicit about dependencies.
d.) write the command being executed for 'apt-get install' to stderr.
validate_image: Fix python2 i386 error, and show value in ValueError.
On python 2 and i386 (32 bit), os.stat will return a long.
There, we see that:
isinstance(os.path.getsize("/etc/passwd"), int) == False
Where as on python 3 or 64 bit arch, the above is True.
That would cause validate_image to raise a ValueError and tests to fail.
